Skip to content

ITS: perVertex do low multiplicty vertices first #14402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f3sch wants to merge 3 commits into from
Closed

ITS: perVertex do low multiplicty vertices first #14402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afe1a1e
ITS: simplify tracker rof/vertices loop
f3sch Jun 10, 2025
d9b6ec3
ITS: perVertex do low multiplicty vertices first
f3sch Jun 10, 2025
9687dd3
ITS: remove stray print
f3sch Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions Detectors/ITSMFT/ITS/tracking/src/Tracker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "ITStracking/TrackingConfigParam.h"

#include "ReconstructionDataFormats/Track.h"
#include <algorithm>
#include <cassert>
#include <format>
#include <cstdlib>
Expand All @@ -45,15 +46,9 @@ void Tracker::clustersToTracks(const LogFunc& logger, const LogFunc& error)
{
LogFunc evalLog = [](const std::string&) {};

double total{0};
mTraits->updateTrackingParameters(mTrkParams);
int maxNvertices{-1};
if (mTrkParams[0].PerPrimaryVertexProcessing) {
for (int iROF{0}; iROF < mTimeFrame->getNrof(); ++iROF) {
maxNvertices = std::max(maxNvertices, (int)mTimeFrame->getPrimaryVertices(iROF).size());
}
}

double total{0};
int iteration{0}, iROFs{0}, iVertex{0};
auto handleException = [&](const auto& err) {
LOGP(error, "Too much memory used during {} in iteration {} in ROF span {}-{} iVtx={}: {:.2f} GB. Current limit is {:.2f} GB, check the detector status and/or the selections.",
Expand All @@ -79,13 +74,24 @@ void Tracker::clustersToTracks(const LogFunc& logger, const LogFunc& error)
double timeTracklets{0.}, timeCells{0.}, timeNeighbours{0.}, timeRoads{0.};
int nTracklets{0}, nCells{0}, nNeighbours{0}, nTracks{-static_cast<int>(mTimeFrame->getNumberOfTracks())};
int nROFsIterations = mTrkParams[iteration].nROFsPerIterations > 0 ? mTimeFrame->getNrof() / mTrkParams[iteration].nROFsPerIterations + bool(mTimeFrame->getNrof() % mTrkParams[iteration].nROFsPerIterations) : 1;
iVertex = std::min(maxNvertices, 0);
logger(std::format("==== ITS {} Tracking iteration {} summary ====", mTraits->getName(), iteration));

total += evaluateTask(&Tracker::initialiseTimeFrame, StateNames[mCurState = TFInit], iteration, logger, iteration);
do {
for (iROFs = 0; iROFs < nROFsIterations; ++iROFs) {
timeTracklets += evaluateTask(&Tracker::computeTracklets, StateNames[mCurState = Trackleting], iteration, evalLog, iteration, iROFs, iVertex);
for (iROFs = 0; iROFs < nROFsIterations; ++iROFs) {
if (mTimeFrame->getPrimaryVertices(iROFs).empty()) {
continue;
}

std::vector<int> vertOrder(mTimeFrame->getPrimaryVerticesNum(iROFs), -1);
if (mTrkParams[0].PerPrimaryVertexProcessing) {
// do low mult. cluster first, should steal less, keep relative order though
std::iota(vertOrder.begin(), vertOrder.end(), 0);
std::stable_sort(vertOrder.begin(), vertOrder.end(), [&](int a, int b) -> bool { return mTimeFrame->getPrimaryVertices(iROFs)[a].getNContributors() < mTimeFrame->getPrimaryVertices(iROFs)[b].getNContributors(); });
iVertex = 0;
}

do {
timeTracklets += evaluateTask(&Tracker::computeTracklets, StateNames[mCurState = Trackleting], iteration, evalLog, iteration, iROFs, vertOrder[iVertex]);
nTracklets += mTraits->getTFNumberOfTracklets();
float trackletsPerCluster = mTraits->getTFNumberOfClusters() > 0 ? float(mTraits->getTFNumberOfTracklets()) / float(mTraits->getTFNumberOfClusters()) : 0.f;
if (trackletsPerCluster > mTrkParams[iteration].TrackletsPerClusterLimit) {
Expand All @@ -104,8 +110,8 @@ void Tracker::clustersToTracks(const LogFunc& logger, const LogFunc& error)
timeNeighbours += evaluateTask(&Tracker::findCellsNeighbours, StateNames[mCurState = Neighbouring], iteration, evalLog, iteration);
nNeighbours += mTimeFrame->getNumberOfNeighbours();
timeRoads += evaluateTask(&Tracker::findRoads, StateNames[mCurState = Roading], iteration, evalLog, iteration);
}
} while (++iVertex < maxNvertices);
} while (vertOrder[iVertex] >= 0 && ++iVertex < mTimeFrame->getPrimaryVerticesNum(iROFs));
}
logger(std::format(" - Tracklet finding: {} tracklets found in {:.2f} ms", nTracklets, timeTracklets));
logger(std::format(" - Cell finding: {} cells found in {:.2f} ms", nCells, timeCells));
logger(std::format(" - Neighbours finding: {} neighbours found in {:.2f} ms", nNeighbours, timeNeighbours));
Expand Down