DataModel: remove unsupported classes #14400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
The code in question conflicts with the modern / standardized specification of std::pmr where the polymorphic_allocators cannot be moved. Given we are not actually using those classes in any case, I am removing them. If we will need the functionality in the future, we will in any case need to reimplement / rethink / verify them.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 264c95b at 2025-06-13 14:52: Full log here. |
mhemmer-cern
pushed a commit
to mhemmer-cern/AliceO2
that referenced
this pull request
Sep 9, 2025
The code in question conflicts with the modern / standardized specification of std::pmr where the polymorphic_allocators cannot be moved. Given we are not actually using those classes in any case, I am removing them. If we will need the functionality in the future, we will in any case need to reimplement / rethink / verify them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in question conflicts with the modern / standardized specification of std::pmr where the polymorphic_allocators cannot be moved.
Given we are not actually using those classes in any case, I am removing
them. If we will need the functionality in the future, we will in any case
need to reimplement / rethink / verify them.