-
Notifications
You must be signed in to change notification settings - Fork 483
ITS: simplify constants + mathutils #14383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 31ac10a at 2025-06-10 16:23: Full log here. |
mpuccio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe there is only one small thing that was not really protected before but we could do better now.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Error while checking build/O2/fullCI_slc9 for 5d3f3f1 at 2025-06-11 00:00: Full log here. |
removes custom definitions of constants in favour of o2-wide ones.
also tries to simplify some math expressions.