Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 6, 2025

  • removes empty source file Road.cxx,
  • cleans up some header includes
  • add move semantics to artefacts (except for Cluster for now since TrackParametrization defines it only for device code)
  • add/correct streamers to artefacts

f3sch added 5 commits June 6, 2025 09:39
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review June 6, 2025 07:47
@f3sch f3sch requested review from fprino, mconcas and shahor02 as code owners June 6, 2025 07:47
@f3sch
Copy link
Collaborator Author

f3sch commented Jun 6, 2025

@mconcas @fprino is this ready for merging?

@davidrohr
Copy link
Collaborator

davidrohr commented Jun 6, 2025

Please don't merge yet, removing the empty Road.cxx breaks the standalone build, where it must also be removed.
Meanwhile, we have a CI check for this, which seems to be broken, since this PR should not have become green.
I'll try to fix the CI check, could you then force-push, check that the C becomes red, and fix the standalone build?

And OK, if it is urgent, just merge, and I will check the standalone CI differently.

@mconcas mconcas merged commit cd40d12 into AliceO2Group:dev Jun 6, 2025
13 checks passed
@mconcas
Copy link
Collaborator

mconcas commented Jun 6, 2025

Please don't merge yet, removing the empty Road.cxx breaks the standalone build, where it must also be removed.

Meanwhile, we have a CI check for this, which seems to be broken, since this PR should not have become green.

I'll try to fix the CI check, could you then force-push, check that the C becomes red, and fix the standalone build?

And OK, if it is urgent, just merge, and I will check the standalone CI differently.

Sorry @davidrohr my github client did not show your message until I merged it.

@f3sch f3sch deleted the its/pr5 branch June 6, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants