Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jun 4, 2025

No description provided.

@ktf ktf requested review from a team and shahor02 as code owners June 4, 2025 09:09
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented Jun 5, 2025

@Barthelemy @knopers8 could you have a look at the error with the new monitoring:

[ 63%] Building CXX object CMakeFiles/testProcessMonitor.dir/test/testProcessMonitor.cxx.o
[ 65%] Building CXX object CMakeFiles/testVerbosity.dir/test/testVerbosity.cxx.o
/sw/SOURCES/Monitoring/v3.19.7/v3.19.7/src/sendMetric.cxx: In function 'int main(int, char**)':
/sw/SOURCES/Monitoring/v3.19.7/v3.19.7/src/sendMetric.cxx:48:52: error: comparison is always true due to limited range of data type [-Werror=type-limits]
   48 |   while ((option = getopt(argc, argv, "hvu:i:m:")) != -1) {
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[ 67%] Linking CXX executable bin/testProcessDetails

@ktf ktf merged commit d19711a into AliceO2Group:dev Jun 5, 2025
10 of 12 checks passed
@knopers8
Copy link
Collaborator

@Barthelemy @knopers8 could you have a look at the error with the new monitoring:

[ 63%] Building CXX object CMakeFiles/testProcessMonitor.dir/test/testProcessMonitor.cxx.o
[ 65%] Building CXX object CMakeFiles/testVerbosity.dir/test/testVerbosity.cxx.o
/sw/SOURCES/Monitoring/v3.19.7/v3.19.7/src/sendMetric.cxx: In function 'int main(int, char**)':
/sw/SOURCES/Monitoring/v3.19.7/v3.19.7/src/sendMetric.cxx:48:52: error: comparison is always true due to limited range of data type [-Werror=type-limits]
   48 |   while ((option = getopt(argc, argv, "hvu:i:m:")) != -1) {
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[ 67%] Linking CXX executable bin/testProcessDetails

@sy-c FYI ⬆️

@ktf
Copy link
Member Author

ktf commented Jun 16, 2025

For the record, after I saw you were on holidays I fixed this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants