Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 4, 2025

please do not squash merge this.

f3sch added 4 commits June 4, 2025 09:40
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch requested review from fprino, mconcas and shahor02 as code owners June 4, 2025 07:41
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Copy link
Contributor

@mpuccio mpuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me, especially given the intention to reduce the code duplication in a follow up PR. Thanks!

@f3sch
Copy link
Collaborator Author

f3sch commented Jun 6, 2025

@fprino, @mconcas the CI error is unrelated, could you please approve?

@mconcas mconcas merged commit 6c94101 into AliceO2Group:dev Jun 6, 2025
13 of 14 checks passed
@f3sch f3sch deleted the its/pr4 branch September 26, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants