Skip to content

[O2-5887] Detect if an empty URL is passed to the CCDB api. #14349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Oct 23, 2025
Merged

[O2-5887] Detect if an empty URL is passed to the CCDB api. #14349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d6818
[O2-5887] Detect if an empty URL is passed to the CCDB api.
Barthelemy Jun 3, 2025
043c8e4
Update testCcdbApi.cxx
Barthelemy Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CCDB/src/CcdbApi.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ void CcdbApi::curlInit()

void CcdbApi::init(std::string const& host)
{
if (host.empty()) {
throw std::invalid_argument("Empty url passed CcdbApi, cannot initialize. Aborting.");
}

// if host is prefixed with "file://" this is a local snapshot
// in this case we init the API in snapshot (readonly) mode
constexpr const char* SNAPSHOTPREFIX = "file://";
Expand Down
9 changes: 8 additions & 1 deletion CCDB/test/testCcdbApi.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,4 +589,11 @@ BOOST_AUTO_TEST_CASE(vectored)
for (auto context : contexts) {
BOOST_CHECK(context.dest.size() != 0);
}
}
}

BOOST_AUTO_TEST_CASE(empty_url)
{
CcdbApi api;
string url = "";
BOOST_CHECK_EXCEPTION(api.init(url), invalid_argument, [](std::invalid_argument const&) -> bool { return true; });
}