Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented May 28, 2025

  • More tweaks to get ROOT::Experimental out of the way
  • RNTuples cannot have / as first character in name

@ktf ktf requested a review from a team as a code owner May 28, 2025 11:44
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented May 28, 2025

@pzhristov this should solve the remaining issues on my side for the new ROOT.

@ktf ktf mentioned this pull request May 28, 2025
@pzhristov
Copy link
Contributor

@ktf It seems we still have the problem in framework:root. Do we need PR #14332 for the successful completion of the tests?

@ktf
Copy link
Member Author

ktf commented May 28, 2025

I fear some of my changes for the new ROOT broke the old one. Checking.

@ktf
Copy link
Member Author

ktf commented May 28, 2025

#14332 is unrelated. Originally, it happened to crash in the same place, which is why I was originally confused, and it should now be good to go.

@pzhristov
Copy link
Contributor

@ktf I confirm that this PR fixes the issue of framework:root with Root v6-36-00.

- More tweaks to get ROOT::Experimental out of the way
- RNTuples cannot have / as first character in name
@ktf
Copy link
Member Author

ktf commented May 30, 2025

Code not used / unchanged until we switch to ROOT v6-36-00.

@ktf ktf merged commit 7335adc into AliceO2Group:dev May 30, 2025
17 checks passed
@ktf
Copy link
Member Author

ktf commented May 30, 2025

Also tested on hyperloop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants