Skip to content

Conversation

@knopers8
Copy link
Collaborator

The optimization was correctly working when we split a range of InputSpecs between different Mergers in a layer, but not when they are time-pipelined. In the commit, we modify the expected number of input messages per cycle to include time-pipeline parameter in the previous and current layer.

The optimization was correctly working when we split a range of InputSpecs between different Mergers in a layer, but not when they are time-pipelined.
In the commit, we modify the expected number of input messages per cycle to include time-pipeline parameter in the previous and current layer.
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank yous

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 2c012d9 at 2025-05-26 17:59:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[21480:internal-dpl-ccdb-backend]: [17:59:44][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[21480:internal-dpl-ccdb-backend]: [17:59:44][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[21480:internal-dpl-ccdb-backend]: [17:59:42][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[21480:internal-dpl-ccdb-backend]: [17:59:42][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/PHS/Config/RecoParams for 1550600800000 (agent_id: alimetal01.cern.ch-1748275163-vGJD0a) with http code: 0
[21480:internal-dpl-ccdb-backend]: [17:59:42][ERROR] File PHS/Config/RecoParams could not be retrieved. No more hosts to try.
[21480:internal-dpl-ccdb-backend]: [17:59:42][FATAL] Unable to find CCDB object PHS/Config/RecoParams/1550600800000
[21480:internal-dpl-ccdb-backend]: [17:59:44][ERROR] Exception while running: Fatal error. Rethrowing.
[21480:internal-dpl-ccdb-backend]: [17:59:44][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 21480 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/6460ab83e8ed9deaf1c66fb9dd232a70379cdef6/slc9_x86-64/o2checkcode/1.0-local147/etc/modulefiles
++ cat
--

Full log here.

@knopers8 knopers8 enabled auto-merge (squash) May 27, 2025 07:01
@knopers8 knopers8 merged commit 2d7a0bd into AliceO2Group:dev May 27, 2025
13 checks passed
@knopers8 knopers8 deleted the fix-mergers-latency-opt branch May 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants