Skip to content

Fix condition to disable V0/Cascade hypothesis in the SVertexer + other minor fix #14324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 2 commits into from
May 23, 2025
Merged

Fix condition to disable V0/Cascade hypothesis in the SVertexer + other minor fix #14324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e9aa2
Fix condition to disable V0/Cascade hypothesis in the SVertexer
shahor02 May 23, 2025
8cd9960
Fix some rejection status assignments
shahor02 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Common/DCAFitter/include/DCAFitter/DCAFitterN.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ class DCAFitterN
FailInv2ndDeriv, // inversion of 2nd derivatives failed
FailCorrTracks, // correction of tracks to updated x failed
FailCloserAlt, // alternative PCA is closer
//
NStatusesDefined
};

static constexpr int getNProngs() { return N; }
Expand Down Expand Up @@ -989,7 +991,7 @@ GPUd() bool DCAFitterN<N, Args...>::minimizeChi2()
}

if (mMaxDZIni > 0 && !roughDZCut()) { // apply rough cut on tracks Z difference
mFitStatus[mCurHyp] = FitStatus::RejTrackX;
mFitStatus[mCurHyp] = FitStatus::RejTrackRoughZ;
return false;
}

Expand Down Expand Up @@ -1063,7 +1065,7 @@ GPUd() bool DCAFitterN<N, Args...>::minimizeChi2NoErr()
setTrackPos(mTrPos[mCurHyp][i], mCandTr[mCurHyp][i]); // prepare positions
}
if (mMaxDZIni > 0 && !roughDZCut()) { // apply rough cut on tracks Z difference
mFitStatus[mCurHyp] = FitStatus::RejTrackX;
mFitStatus[mCurHyp] = FitStatus::RejTrackRoughZ;
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions Detectors/Vertexing/include/DetectorsVertexing/SVertexHypothesis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SVertexHypothesis

bool check(float p2Pos, float p2Neg, float p2V0, float ptV0) const
{ // check if given mass and pt is matching to hypothesis
return mPars[SigmaM] > 0 && check(calcMass(p2Pos, p2Neg, p2V0), ptV0);
return mPars[SigmaM] >= 0.f && check(calcMass(p2Pos, p2Neg, p2V0), ptV0);
}
bool check(float mass, float pt) const
{ // check if given mass and pt is matching to hypothesis
Expand Down Expand Up @@ -151,7 +151,7 @@ class SVertex3Hypothesis

bool check(float p2Pos, float p2Neg, float p2Bach, float p2Tot, float ptV0) const
{ // check if given mass and pt is matching to hypothesis
return mPars[SigmaM] > 0 && check(calcMass(p2Pos, p2Neg, p2Bach, p2Tot), ptV0);
return mPars[SigmaM] >= 0.f && check(calcMass(p2Pos, p2Neg, p2Bach, p2Tot), ptV0);
}

bool check(float mass, float pt) const
Expand Down