[EMCAL-1152] EMCAL: Fix cpplint errors #14301
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes changes to:
Changes are mostly:
Why is unary operator& dangerous?
Example: let's say we have a class MyClass.
Now the Code:
MyClass obj;
MyClass* ptr = &obj; // gets the memory address of obj
seems logical and correct, however, if one has the unary operator& defined within the class to return a reference of some member MyMember of the class, we would have:
MyClass obj;
MyMember* ptr = &obj; // gets the memory address of member of obj
It is better to write a properly named function that returns a reference to the member if it is needed:
MyMember& currentMember() { return mMyMember; }