Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented May 19, 2025

Needs alisw/alidist#5885

ITS included a header only of the library but essentially did not depend on it for a while now.
However, some TRD code did explicitly. This adds the library as a dependency to O2 (which it anyways was through root and onnx), removes the header file and rectifies the include in trd.

@f3sch f3sch requested review from a team, bazinski, fprino, mconcas, shahor02 and wille10 as code owners May 19, 2025 15:34
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented May 19, 2025

Error while checking build/O2/fullCI_slc9 for f6e5460 at 2025-05-21 01:51:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14295-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/TRDEventDisplayFeedSpec.h:13:10: fatal error: nlohmann/json.hpp: No such file or directory
/sw/SOURCES/O2/14295-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/TRDEventDisplayFeedSpec.h:13:10: fatal error: nlohmann/json.hpp: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@f3sch f3sch force-pushed the its/json branch 2 times, most recently from 667a4cd to 449d83e Compare May 21, 2025 14:13
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 667a4cd at 2025-05-21 16:41:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14295-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/TRDEventDisplayFeedSpec.h:13:10: fatal error: nlohmann/json.hpp: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@mconcas mconcas merged commit 3c38c31 into AliceO2Group:dev May 27, 2025
12 checks passed
@f3sch f3sch deleted the its/json branch May 27, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants