Skip to content

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented May 18, 2025

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lietava lietava marked this pull request as ready for review May 18, 2025 13:26
@lietava lietava requested a review from a team as a code owner May 18, 2025 13:26
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 0ea2659 at 2025-05-18 17:49:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14291-slc9_x86-64/0/DataFormats/Detectors/CTP/src/Configuration.cxx:936:18: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for cebc039 at 2025-05-19 10:19:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14291-slc9_x86-64/0/DataFormats/Detectors/CTP/src/Configuration.cxx:936:18: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for ee87daf at 2025-05-19 14:09:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile cpvreco.log
./sim-challenge.logcpvreco.log:[19078:internal-dpl-ccdb-backend]: [14:09:10][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logcpvreco.log-[19078:internal-dpl-ccdb-backend]: [14:09:10][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-cpv-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alimetal01.cern.ch-1747656549-W6wSAp) with http code: 0
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[19078:internal-dpl-ccdb-backend]: [14:09:10][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-cpv-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 19078 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 19078 (exit 128)
./sim-challenge.log[INFO]    - First error: [14:09:10][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (19078) had at least one message above severity 7: Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5407:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5469:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
[0 more errors; see full log]

Full log here.

@lietava
Copy link
Contributor Author

lietava commented May 19, 2025

Hi @shahor02 , is it CTP problem ?

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lietava no, it failed due to the CCDB access timeout.
But, given the amount of changes (which go well beyond the tile of the PR), have you tested it with the real data?

@lietava
Copy link
Contributor Author

lietava commented May 19, 2025

@shahor02 : the changes does not touch core docoder - they are only monitor counter.
checkConsistency option is off in decoding - it is used only in qc.
Nevertheless I did following check with data.
I compared:
o2-raw-tf-reader-workflow -b --onlyDet CTP --input-data list.txt | o2-ctp-reco-workflow -b --no-lumi --ctpinputs-decoding
against
o2-raw-tf-reader-workflow --input-data list.txt --onlyDet CTP | o2-ctp-reco-workflow --no-lumi | o2-ctp-entropy-encoder-workflow | o2-ctf-writer-workflow --onlyDet CTP
o2-ctf-reader-workflow --ctf-input listctf.txt --onlyDet CTP --allow-missing-detectors | o2-ctp-digit-writer -b

and digits are identical.

@lietava
Copy link
Contributor Author

lietava commented May 19, 2025

and now also compared digits before changes in code (28/11/24) with new one - ok.

@shahor02 shahor02 merged commit e2f0fa3 into AliceO2Group:dev May 19, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants