-
Notifications
You must be signed in to change notification settings - Fork 483
Preparation for Pythia8315 #14286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for Pythia8315 #14286
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 8910717 at 2025-05-19 01:17: Full log here. |
|
@sawenzel I am not sure why the fullCI fails, the inconsistency between the number of expected and processed primary particles is not related to the changes in the PR. |
|
@pzhristov : The fullCI passes with your mods. Now the question is what will happen when we go to Pythia8314, where the change will be applied again? |
|
@sawenzel The problem is that we add some "nuclei" with isospin one in the code itself, and I did not see them when checking the external file. I can change the logic and mask only if the isospin is 9. |
|
Error while checking build/O2/fullCI_slc9 for 83d2122 at 2025-05-28 17:42: Full log here. |
|
Error while checking build/O2/fullCI_slc9 for 9ea3a70 at 2025-05-29 07:49: Full log here. |
|
Error while checking build/O2/fullCI_slc9 for d35f2ca at 2025-06-01 02:10: Full log here. |
|
Since isospin 9 is used to indicate beam remnants, it cannot simply be masked. Additional changes will address this issue. |
|
@sawenzel @jackal1-66 I confirm that these changes work well with Pythia8.315 and the beam remnants are treated correctly in Geant4 (no exceptions). It is possible that there was a bug in the status code introduced in 8.314 that was fixed later in 8.315, but I did not investigate further. The compilation error on aarch64 is in Monitoring and not related to this PR. If you agree, I will merge it and prepare a PR to bump Pythia8 |
Mask the isospin information in the PDG code.
Use nCollND() instead of the deprecated nCollNDTot().