Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented May 15, 2025

As Gandiva does not handle conversions with unsigned integer types internally, it is not trivial to apply filters for some of the columns. This feature creates a workaround, for example the following code

  Configurable<int> cvalue{"cvalue", 1, "test value"};
  Filter testFilter = o2::aod::track::tpcNClsShared < as<uint8_t>(cvalue);

will create a valid filter where cvalue will be properly updated and cast to uint8_t for comparison with the column of the same type, but it can be provided normally in configuration JSON as a simple int unlike for the uint8_t configurable that will be parsed as a character by C++.

@aalkin aalkin requested a review from a team as a code owner May 15, 2025 11:54
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aalkin aalkin requested a review from ktf May 15, 2025 18:36
@ktf ktf merged commit 88baea9 into AliceO2Group:dev May 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants