Skip to content

DPL: keep codechecker happy #14270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
May 13, 2025
Merged

DPL: keep codechecker happy #14270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Detectors/CTP/reconstruction/src/RawDataDecoder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,9 @@ int RawDataDecoder::checkReadoutConsistentncy(o2::pmr::vector<CTPDigit>& digits,
continue;
}
mClassCountersA[i]++;
if (cls->descriptor == nullptr)
if (cls->descriptor == nullptr) {
continue;
}
uint64_t clsinpmask = cls->descriptor->getInputsMask();
uint64_t diginpmask = digit.CTPInputMask.to_ullong();
if (!((clsinpmask & diginpmask) == clsinpmask)) {
Expand All @@ -632,8 +633,9 @@ int RawDataDecoder::checkReadoutConsistentncy(o2::pmr::vector<CTPDigit>& digits,
// if inps => class mask
for (auto const& cls : mCTPConfig.getCTPClasses()) {
// cls.printStream(std::cout);
if (cls.descriptor == nullptr)
if (cls.descriptor == nullptr) {
continue;
}
uint64_t clsinpmask = cls.descriptor->getInputsMask(); // class definition
uint64_t diginpmask = digit.CTPInputMask.to_ullong();
uint64_t digclsmask = digit.CTPClassMask.to_ullong();
Expand Down
6 changes: 4 additions & 2 deletions Detectors/CTP/workflow/src/RawDecoderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,19 @@ void RawDecoderSpec::endOfStream(framework::EndOfStreamContext& ec)
std::cout << std::endl;
LOG(info) << " Lost due to the shift:" << mDecoder.getLostDueToShift();
LOG(info) << "Number of missing TF:" << nmiss << std::endl;
if (mDecoder.getErrorIR() || mDecoder.getErrorTCR())
if (mDecoder.getErrorIR() || mDecoder.getErrorTCR()) {
LOG(error) << "# of IR errors:" << mDecoder.getErrorIR() << " TCR errors:" << mDecoder.getErrorTCR() << std::endl;
}
std::array<uint64_t, o2::ctp::CTP_NCLASSES> clsA = mDecoder.getClassCountersA();
std::array<uint64_t, o2::ctp::CTP_NCLASSES> clsB = mDecoder.getClassCountersB();
std::array<uint64_t, o2::ctp::CTP_NCLASSES> clsEA = mDecoder.getClassErrorsA();
std::array<uint64_t, o2::ctp::CTP_NCLASSES> clsEB = mDecoder.getClassErrorsB();

for (int i = 0; i < o2::ctp::CTP_NCLASSES; i++) {
bool print = clsA[i] > 0 || clsB[i] > 0 || clsEA[i] > 0 || clsEB[i] > 0;
if (clsEA[i])
if (clsEA[i]) {
LOG(error) << " Class without inputs:";
}
LOG(important) << "CLASS:" << i << " Cls=>Inp:" << clsA[i] << " Inp=>Cls:" << clsB[i] << " ErrorsCls=>Inps:" << clsEA[i] << " MissingInps=>Cls:" << clsEB[i];
}
}
Expand Down