Skip to content

Conversation

@davidrohr
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for d834323 at 2025-05-12 15:00:

## sw/BUILD/O2-RTC-test-latest/log
/tmp/o2cagpu_rtc_131_740876268_9.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:26447:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_77.hip:26450:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:26447:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_9.hip:26450:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_1.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_1.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_1.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_1.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_1.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_57.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_57.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_57.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_57.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_57.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:26447:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_55.hip:26450:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:26447:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_49.hip:26450:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_87.hip:17265:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_71.hip:17265:33: error: constexpr if condition is not a constant expression
       |                                ^/tmp/o2cagpu_rtc_131_740876268_71.hip:17270:37: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_87.hip:17270:37: error: constexpr if condition is not a constant expression
 17270 |             if/tmp/o2cagpu_rtc_131_740876268_71.hip:17383:33: error: constexpr if condition is not a constant expression
 GPUCA_RTC_/tmp/o2cagpu_rtc_131_740876268_71.hip:17407:39: error: constexpr if condition is not a constant expression
CONSTEXPR /tmp/o2cagpu_rtc_131_740876268_71.hip:17440:29: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_87.hip:17383:33: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_87.hip:17407:39: error: constexpr if condition is not a constant expression
/tmp/o2cagpu_rtc_131_740876268_87.hip:17440:29: error: constexpr if condition is not a constant expression
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 1f80afa at 2025-05-12 22:47:

No log files found

Full log here.

@shahor02
Copy link
Collaborator

@davidrohr, if I understood correctly, the TrackTPC.mdEdxAlt will not be filled at all if dEdxClusterRejectionFlagMask == dEdxClusterRejectionFlagMaskAlt? Then the TrackQC will not be filled correctly at

const auto& dEdx = tpcOrig.getdEdx().dEdxTotTPC > 0 ? tpcOrig.getdEdx() : tpcOrig.getdEdxAlt();
.
One should either assign the TrackTPC.mdEdxAlt from the regular dedx or at least use the latter in the AODProducer to fill the table.

@davidrohr
Copy link
Collaborator Author

@davidrohr, if I understood correctly, the TrackTPC.mdEdxAlt will not be filled at all if dEdxClusterRejectionFlagMask == dEdxClusterRejectionFlagMaskAlt? Then the TrackQC will not be filled correctly at

const auto& dEdx = tpcOrig.getdEdx().dEdxTotTPC > 0 ? tpcOrig.getdEdx() : tpcOrig.getdEdxAlt();

.
One should either assign the TrackTPC.mdEdxAlt from the regular dedx or at least use the latter in the AODProducer to fill the table.

I changed it such that it fills the TrackTPC.mdEdxAlt with the same data as TrackTPC.mdEdx.

@davidrohr
Copy link
Collaborator Author

davidrohr commented May 13, 2025

I did not manage to find a better workaround for GPU: Workaround for Clang Frontend issue

My current attempt is here, but doesn't work: https://godbolt.org/z/MnEd5G38Y

Will retrry in the future, or we have to wait for ROCm to bump to Clang20 and switch to -std=c++23.

Merging as is.

@davidrohr davidrohr merged commit 89b35ba into AliceO2Group:dev May 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants