Skip to content

GPU: debug files of multiple GPU Reconstruciton instances shall not overwrite each other #14248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
May 7, 2025
Merged

GPU: debug files of multiple GPU Reconstruciton instances shall not overwrite each other #14248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GPU/GPUTracking/Base/GPUReconstruction.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ GPUReconstruction::GPUReconstruction(const GPUSettingsDeviceBackend& cfg) : mHos
throw std::invalid_argument("Cannot be slave to a slave");
}
mMaster = cfg.master;
mSlaveId = cfg.master->mSlaves.size();
cfg.master->mSlaves.emplace_back(this);
}
param().SetDefaults(mGRPSettings.get());
Expand Down
2 changes: 2 additions & 0 deletions GPU/GPUTracking/Base/GPUReconstruction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ class GPUReconstruction
// Helpers to fetch processors from other shared libraries
virtual void GetITSTraits(std::unique_ptr<o2::its::TrackerTraits>* trackerTraits, std::unique_ptr<o2::its::VertexerTraits>* vertexerTraits, std::unique_ptr<o2::its::TimeFrame>* timeFrame);
bool slavesExist() { return mSlaves.size() || mMaster; }
int slaveId() { return mSlaveId; }

// Getters / setters for parameters
DeviceType GetDeviceType() const;
Expand Down Expand Up @@ -339,6 +340,7 @@ class GPUReconstruction

GPUReconstruction* mMaster = nullptr; // Ptr to a GPUReconstruction object serving as master, sharing GPU memory, events, etc.
std::vector<GPUReconstruction*> mSlaves; // Ptr to slave GPUReconstructions
int mSlaveId = -1; // Id of this slave (-1 for master)

// Others
bool mInitialized = false;
Expand Down
3 changes: 2 additions & 1 deletion GPU/GPUTracking/Global/GPUChainTracking.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ int32_t GPUChainTracking::Init()
}

if (GetProcessingSettings().debugLevel >= 6) {
mDebugFile->open(mRec->IsGPU() ? "GPU.out" : "CPU.out");
std::string filename = std::string(mRec->IsGPU() ? "GPU" : "CPU") + (mRec->slaveId() != -1 ? (std::string("_slave") + std::to_string(mRec->slaveId())) : std::string(mRec->slavesExist() ? "_master" : "")) + ".out";
mDebugFile->open(filename.c_str());
}

return 0;
Expand Down