Skip to content

DPL: do not check for events unless we were notified #14246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ktf wants to merge 1 commit into from
Closed

DPL: do not check for events unless we were notified #14246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Framework/Core/src/DataProcessingDevice.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ void on_socket_polled(uv_poll_t* poller, int status, int events)
case UV_READABLE: {
O2_SIGNPOST_EVENT_EMIT(device, sid, "socket_state", "Data pending on socket for channel %{public}s", context->name);
context->state->loopReason |= DeviceState::DATA_INCOMING;
context->channelInfo->readPolled = true;
} break;
case UV_WRITABLE: {
O2_SIGNPOST_END(device, sid, "socket_state", "Socket connected for channel %{public}s", context->name);
Expand Down Expand Up @@ -1672,6 +1673,10 @@ void DataProcessingDevice::doPrepare(ServiceRegistryRef ref)
channelSpec.name.c_str(), (int)info.state, info.parts.Size());
continue;
}
if (info.readPolled == false) {
O2_SIGNPOST_END(device, cid, "channels", "Channel %s which is in state %d did not request reading.", channelSpec.name.c_str(), (int)info.state);
continue;
}
auto& socket = info.channel->GetSocket();
// If we have pending events from a previous iteration,
// we do receive in any case.
Expand Down