-
Notifications
You must be signed in to change notification settings - Fork 483
[EMCAL-689] EMCAL/Geometry: Add function to load alignment matrix fro… #14237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, fine, but why do you need a data member for the ccdbManager?
The latter is anyway a singleton, it is enough to do all operations on the ...::instance().
Ah good point, I will change this quickly. Thanks @shahor02 |
|
I had the impression that this was just a temporary hack to collect data for the real alignment. @mhemmer-cern, is that not so? |
No you are right, this is just temporary solution till we have an EMCal alignment object that we trust and with what we would want to create a new official AlignmentObject. |
|
Error while checking build/O2/fullCI_slc9 for 56894e1 at 2025-05-13 23:59: Full log here. |
|
I just force pushed to restart the build. In general I think this can be merged now. The CCDB access is now done in an isolated way. The actual usage of this needs to be implemented in O2Physics, for which we need this PR first merged. |
jokonig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…m CCDB - Add function `SetMisalMatrixFromCcdb` to set the missalignment matrices for the EMCal via the CCDB. This way they are not laoded from the GeoManager. The function expects a path inside the ccdb, which by default is set to `"Users/m/mhemmer/EMCAL/Config/GeometryAligned"` and the timestamp. Currently in the CCDB we only have the old Run 2 alignment object. Once we have the new alignment objects we can uplaod them and via the correct time stamp load them fittingly.
…m CCDB
SetMisalMatrixFromCcdbto set the missalignment matrices for the EMCal via the CCDB. This way they are not laoded from the GeoManager. The function expects a path inside the ccdb, which by default is set to"Users/m/mhemmer/EMCAL/Config/GeometryAligned"and the timestamp. Currently in the CCDB we only have the old Run 2 alignment object. Once we have the new alignment objects we can uplaod them and via the correct time stamp load them fittingly.