Skip to content

Conversation

@GiorgioAlbertoLucia
Copy link
Contributor

I added Lithium 4 pdg code and mass to the physics constants

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

shahor02
shahor02 previously approved these changes May 2, 2025
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st commit approval

@alibuild
Copy link
Collaborator

alibuild commented May 3, 2025

Error while checking build/O2/fullCI_slc9 for 39dab7e at 2025-05-03 13:53:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile tpcreco.log
./sim-challenge.logtpcreco.log:[9352:internal-dpl-ccdb-backend]: [13:53:34][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logtpcreco.log-[9352:internal-dpl-ccdb-backend]: [13:53:34][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:33][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:33][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alimetal04.cern.ch-1746273211-zBgMym) with http code: 0
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:33][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:33][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:34][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[9352:internal-dpl-ccdb-backend]: [13:53:34][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 9352 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 9352 (exit 128)
./sim-challenge.log[INFO]    - First error: [13:53:33][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (9352) had at least one message above severity 7: Unable to find CCDB object CTP/Calib/OrbitReset/1546300800000
./grp.log[ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./grp.log[ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch//GLO/Calib/MeanVertex for 1546300800000 (agent_id: alimetal04.cern.ch-1746273041-XbF6dJ) with http code: 0
./grp.log[ERROR] File /GLO/Calib/MeanVertex could not be retrieved. No more hosts to try.
./grp.log[ERROR] Unable to find object /GLO/Calib/MeanVertex/1546300800000, Aborting
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
[0 more errors; see full log]

Full log here.

@f3sch
Copy link
Collaborator

f3sch commented May 3, 2025

Tagging @vkucera for the usual comment

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GiorgioAlbertoLucia , how did you produce the changes? Did you add them by hand or using the Python script? The updated script is not added in the PR.

@GiorgioAlbertoLucia
Copy link
Contributor Author

Hello @vkucera, thank you for your reply.
I misunderstood how that file was being generated, so I can confirm you that I manually added the lines to the file.

From what I understand now, I should add
kLithium4 = (pdgcode)
to the make_pdg_header.py file in the pdg class and this should add both the pdg and the mass (that I confirmed is included in the O2DatabasePDG.h file) to the PhysicsConstants.h file. I noticed that the python code only prints the file to terminal. Am I correct in assuming that I should just manually run the script and copy paste that output to the PhysicsConstants.h file? Is there another recommended way to do it?

@vkucera
Copy link
Collaborator

vkucera commented May 4, 2025

Yes, please generate the PDG part of the header using the script and paste it in the header.

@vkucera vkucera requested a review from shahor02 May 4, 2025 15:02
@alibuild
Copy link
Collaborator

alibuild commented May 10, 2025

Error while checking build/O2/fullCI_slc9 for 5c3758a at 2025-05-25 23:40:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[31960:internal-dpl-ccdb-backend]: [23:40:01][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[31960:internal-dpl-ccdb-backend]: [23:40:01][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[31960:internal-dpl-ccdb-backend]: [23:39:59][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[31960:internal-dpl-ccdb-backend]: [23:39:59][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alimetal01.cern.ch-1748209177-RPqpEs) with http code: 0
[31960:internal-dpl-ccdb-backend]: [23:39:59][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[31960:internal-dpl-ccdb-backend]: [23:39:59][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000
[31960:internal-dpl-ccdb-backend]: [23:40:01][ERROR] Exception while running: Fatal error. Rethrowing.
[31960:internal-dpl-ccdb-backend]: [23:40:01][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 31960 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 31960 (exit 128)
[INFO]    - First error: [23:39:59][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (31960) had at least one message above severity 7: Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/1b099855ad59c23e551dfd040bdbecbfa77b41a4/slc9_x86-64/o2checkcode/1.0-local137/etc/modulefiles
++ cat
--

Full log here.

@GiorgioAlbertoLucia
Copy link
Contributor Author

Hi @shahor02, I had to apply some changes, therefore your first approval was removed. Could you approve this PR again, please?

@vkucera
Copy link
Collaborator

vkucera commented May 30, 2025

@shahor02 @ktf @sawenzel Can you merge this, please?

@shahor02 shahor02 merged commit a81a238 into AliceO2Group:dev May 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants