Skip to content

Conversation

@ehellbar
Copy link
Collaborator

Here I assume that these values are established and that there should generally be no reason to change them on the fly via the CONFIG_EXTRA_PROCESS_ env var.

This would make it easier to define the MCH parameters in https://github.com/ehellbar/AliceO2/blob/dev/prodtests/full-system-test/dpl-workflow.sh#L122 for the oxygen period via the CONFIG_EXTRA_PROCESS_ env var. Here specifically, adding MCHTimeClusterizer.irFramesOnly=true; only in case of ITS in the run would be difficult

@ehellbar ehellbar requested a review from a team as a code owner April 30, 2025 14:14
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar
Copy link
Collaborator Author

actually, if you prefer to keep it like before, I could also move only the MCHTimeClusterizer.irFramesOnly=true; part out of the if condition, which should be sufficient.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine like here, if needed, there MCH_CONFIG_KEY settings can be overridden by the CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow

@davidrohr davidrohr merged commit 2482a56 into AliceO2Group:dev May 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants