Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Apr 17, 2025

The first change is of course just a visual aid but the second one I find useful for quick comparisons of parameters (and the machinery was anyways there). Let me know what you think.
image

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review April 17, 2025 18:27
@f3sch f3sch requested a review from sawenzel as a code owner April 17, 2025 18:27
Copy link
Collaborator

@sawenzel sawenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a good idea. I just have a minor comment on variable naming.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 22, 2025

Thanks for the review! (There are only two things hard in programming; cache invalidation, naming things and off by one errors :)).

@f3sch f3sch merged commit cde32e7 into AliceO2Group:dev Apr 23, 2025
13 checks passed
@f3sch f3sch deleted the confkey/print branch April 23, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants