Skip to content

Conversation

@pillot
Copy link
Collaborator

@pillot pillot commented Apr 16, 2025

When the track is extrapolated to the vertex (or MFT) without multiple scattering correction, the absorber material crossed (for e.g. E loss correction) is estimated by propagating the track from downstream, without information from upstream. This PR allows to provide an upstream point (typically the vertex or the MFT track position) to better estimate the path through the absorber. If no information is provided, the behavior is unchanged.

@pillot pillot requested review from a team and shahor02 as code owners April 16, 2025 14:12
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lmassacr
Copy link
Contributor

Hi @pillot, looks good to me. I just wonder if some changes need to be propagated accordingly in the DQ or QC framework, as I think the various extrapolation functions are used at several places. Since I saw you initialized the additional arguments in all functions to a default, I guess it might be fine, and those default values will always be picked whatever the extrapolation function was used before (even if with less arguments). But I just want to make sure with you.

@pillot
Copy link
Collaborator Author

pillot commented Apr 17, 2025

Hi @lmassacr , yes, these changes should be transparent. The extra arguments are optional and if not provided (i.e. if zUpstream = nullopt, which is the default), as it is the case now everywhere these functions are used, the extrapolation is the same as before.
The idea would be to test if the MCH-MFT matching could be slightly improved by providing an upstream position in the extrapolation without Branson correction, then change the code in DQ accordingly.

@lmassacr
Copy link
Contributor

Hi @pillot, ok thanks for the clarification. I am approving.

@pillot pillot merged commit 99c08d3 into AliceO2Group:dev Apr 17, 2025
14 checks passed
@pillot pillot deleted the improve_extrap_to_vtx_wo_branson branch April 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants