Skip to content

Conversation

@davidrohr
Copy link
Collaborator

Should fix the problem with the FullCI

@davidrohr davidrohr requested a review from a team as a code owner April 13, 2025 12:03
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@davidrohr davidrohr merged commit 7e212e1 into AliceO2Group:dev Apr 13, 2025
12 of 13 checks passed
@ktf
Copy link
Member

ktf commented Apr 13, 2025

For the record, this is an actual issue in the simulation, and we should not mask it out, probably.

@davidrohr
Copy link
Collaborator Author

Then @sawenzel shoukd have a look.
However, the check did not really trigger on the exception, since it excludes G4Exception, it only triggered on the debug message that one can change the exeption severity. So I think my change not tontrigger on that is anyway correct? One should rather trigger on the exception itself.

@ktf
Copy link
Member

ktf commented Apr 14, 2025

Fair enough. We were indeed looking into it friday. We should probably catch the exceptions then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants