Skip to content

Fix for TPC edge clusters in CTF decoding #14161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Apr 18, 2025
Merged

Fix for TPC edge clusters in CTF decoding #14161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions GPU/GPUTracking/DataCompression/GPUTPCDecompressionKernels.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ GPUdii() void GPUTPCDecompressionKernels::Thread<GPUTPCDecompressionKernels::ste
ClusterNative* clout = buffer + decompressor.mNativeClustersIndex[linearIndex];
uint32_t end = offsets[linearIndex] + ((linearIndex >= decompressor.mInputGPU.nSliceRows) ? 0 : decompressor.mInputGPU.nSliceRowClusters[linearIndex]);
TPCClusterDecompressionCore::decompressHits(cmprClusters, offsets[linearIndex], end, clout);
if (processors.param.rec.tpc.clustersEdgeFixDistance > 0.f) {
constexpr GPUTPCGeometry geo;
for (uint32_t k = 0; k < outputAccess->nClusters[iSector][iRow]; k++) {
auto& cluster = buffer[k];
if (cluster.getFlags() & ClusterNative::flagEdge) {
auto padF = cluster.getPad();
float distEdge = padF < geo.NPads(iRow) / 2 ? padF : geo.NPads(iRow) - 1 - padF;
if (distEdge > processors.param.rec.tpc.clustersEdgeFixDistance) {
cluster.setFlags(cluster.getFlags() ^ ClusterNative::flagEdge);
}
}
}
}
if (processors.param.rec.tpc.clustersShiftTimebins != 0.f) {
for (uint32_t k = 0; k < outputAccess->nClusters[iSector][iRow]; k++) {
auto& cl = buffer[k];
Expand Down
13 changes: 13 additions & 0 deletions GPU/GPUTracking/DataCompression/TPCClusterDecompressor.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,19 @@ int32_t TPCClusterDecompressor::decompress(const CompressedClusters* clustersCom
ClusterNative* clout = buffer + clusters[i][j].size();
uint32_t end = offsets[i][j] + ((i * GPUCA_ROW_COUNT + j >= clustersCompressed->nSliceRows) ? 0 : clustersCompressed->nSliceRowClusters[i * GPUCA_ROW_COUNT + j]);
TPCClusterDecompressionCore::decompressHits(*clustersCompressed, offsets[i][j], end, clout);
if (param.rec.tpc.clustersEdgeFixDistance > 0.f) {
constexpr GPUTPCGeometry geo;
for (uint32_t k = 0; k < clustersNative.nClusters[i][j]; k++) {
auto& cluster = buffer[k];
if (cluster.getFlags() & ClusterNative::flagEdge) {
auto padF = cluster.getPad();
float distEdge = padF < geo.NPads(j) / 2 ? padF : geo.NPads(j) - 1 - padF;
if (distEdge > param.rec.tpc.clustersEdgeFixDistance) {
cluster.setFlags(cluster.getFlags() ^ ClusterNative::flagEdge);
}
}
}
}
if (param.rec.tpc.clustersShiftTimebins != 0.f) {
for (uint32_t k = 0; k < clustersNative.nClusters[i][j]; k++) {
auto& cl = buffer[k];
Expand Down
1 change: 1 addition & 0 deletions GPU/GPUTracking/Definitions/GPUSettingsList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ AddOptionRTC(tubeChi2, float, 5.f * 5.f, "", 0, "Max chi2 to mark cluster adjace
AddOptionRTC(tubeMaxSize2, float, 2.5f * 2.5f, "", 0, "Square of max tube size (normally derrived from tpcTubeChi2)")
AddOptionRTC(clustersShiftTimebins, float, 0, "", 0, "Shift of TPC clusters (applied during CTF cluster decoding)")
AddOptionRTC(clustersShiftTimebinsClusterizer, float, 0, "", 0, "Shift of TPC clusters (applied during CTF clusterization)")
AddOptionRTC(clustersEdgeFixDistance, float, 0.f, "", 0, "If >0, revert cluster.flag edge bit distance to edge exceeds this parameter (fixed during CTF decoding)")
AddOptionRTC(defaultZOffsetOverR, float, 0.5210953f, "", 0, "Shift of TPC clusters (applied during CTF cluster decoding)")
AddOptionRTC(PID_EKrangeMin, float, 0.47f, "", 0, "min P of electron/K BB bands crossing")
AddOptionRTC(PID_EKrangeMax, float, 0.57f, "", 0, "max P of electron/K BB bands crossing")
Expand Down