Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Apr 8, 2025

This is actually a workaround. The real issue is that timer at the moment are
completely outside of the data streaming and therefore do not have access to
the DataTakingService, where the proper calculation for the run number happens
and it's cached.

OK for now.

In the future we should make sure that the LifetimeHelpers::enumerate
gets a "Streaming" context, not the global one.

This is actually a workaround. The real issue is that timer at the moment are
completely outside of the data streaming and therefore do not have access to
the DataTakingService, where the proper calculation for the run number happens
and it's cached.

OK for now.

In the future we should make sure that the LifetimeHelpers::enumerate
gets a "Streaming" context, not the global one.
@ktf ktf requested a review from a team as a code owner April 8, 2025 07:06
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented Apr 8, 2025

@ehellbar can you suggest a range of Run Numbers to use for special meanings (e.g. errors?)? Where is the list of the currently reserved numbers?

@alibuild
Copy link
Collaborator

alibuild commented Apr 8, 2025

Error while checking build/O2/fullCI_slc9 for cab3b23 at 2025-04-08 18:04:

## sw/BUILD/SHERPA-latest/log
configure: error: Sqlite3 required but not found.

Full log here.

@ehellbar
Copy link
Collaborator

ehellbar commented Apr 8, 2025

Hi @ktf,

most of the messages are gone, but there seem to be still a few sources of DataHeaders with run number 0 left. We get messages from ITS and MFT QC proxies during the run, and the usual barrage of messages at the end of a run.

Tests on STG (using custom O2PDPSuite/epn-20250408.1-DDv1.6.6-QCv1.170.0-flp-suite-v1.57.1-1), number of INVALID runNumber messages:

without this PR, run 1819: 2.44 per second + 182 after STOP (http://alio2-cr1-hv-mvs00.cern.ch:8081/?q={%22run%22:{%22match%22:%221819%22},%22message%22:{%22match%22:%22%25INVALID%20run%25%22},%22severity%22:{%22in%22:%22E%20F%22}})

with this PR, run 1822: 0.08 per second + 182 after STOP (http://alio2-cr1-hv-mvs00.cern.ch:8081/?q={%22partition%22:{%22match%22:%222tq5oUHUzUW%22},%22message%22:{%22match%22:%22%25INVALID%20run%25%22},%22severity%22:{%22in%22:%22E%20F%22}})

NB: these are on FLPs on STG. In PROD, we also see messages on EPNs at the end of run which we don't see on STG.

@ktf ktf merged commit 24c97f2 into AliceO2Group:dev Apr 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants