Skip to content

Conversation

@miranov25
Copy link
Contributor

[WIP] Add TRD Tracklets to Skimmed Data

This PR introduces TRD tracklet support in the time series skimming workflow.

✅ Changes:

  • Added 6 TRD tracklets (8 bytes each) per track to skimmed data output.

⚠️ Notes:

  • Currently marked as draft: filling the std::vector of tracklets is not yet implemented.
  • Once the data filling is in place, this will enable TRD PID validation and calibration via skimmed time series.

Tagging:
@f3sch — draft for now, pending data filling logic.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@miranov25
Copy link
Contributor Author

async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Comment on lines +194 to +201
const auto & tracksTRD = mTPCOnly ? gsl::span<o2::trd::TrackTRD>() : recoData.getITSTPCTRDTracks<o2::trd::TrackTRD>();
const auto& trklets = mTPCOnly ? gsl::span<const o2::trd::Tracklet64>():recoData.getTRDTracklets();
std::unordered_map<unsigned int, unsigned int> indicesTRDTPC; // TPC track index -> TRD-TPC track index.
// loop over all TRD tracks and map them to TPC tracks
for (int i = 0; i < tracksTRD.size(); ++i) {
//auto trackTPC = tracksTRD[i].getRefTPC().getIndex();
//if (trackTPC >= 0) indicesTRDTPC[trackTPC] = i;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly do you want to store? TRD track are using not the raw (o2::trd::Tracklet64) tracklets but calibrated ones, see https://github.com/AliceO2Group/AliceO2/blob/dev/Detectors/TPC/calibration/SpacePoints/src/TrackInterpolation.cxx#L445-L452 for the access to tracklets associated to the track.

@shahor02
Copy link
Collaborator

shahor02 commented Apr 7, 2025

@miranov25 see https://github.com/AliceO2Group/AliceO2/compare/dev...shahor02:AliceO2:pr_trd_mi?expand=1

You can fetch my https://github.com/shahor02/AliceO2/tree/pr_trd_mi branch and continue from there.
Here: shahor02@c4390f2#diff-4b75d47beea084f3ade0437e5955ec1d76a84099764bcd67c52e56dcc2106724R1380 I collect in the vector the copies of attached tracklets, but then I don't know what exactly you want to store.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label May 8, 2025
@miranov25
Copy link
Contributor Author

I will apply the proposed @Solution from @shahor02 . I did not have time yet as we had a crisis with the 2023 PbPb production.

@github-actions github-actions bot closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants