Skip to content

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Apr 5, 2025

Finishing orbit reset and orbit reset via zmq using o2-ctp-proxy

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lietava lietava marked this pull request as ready for review April 5, 2025 14:50
@lietava lietava requested a review from a team as a code owner April 5, 2025 14:50
@lietava
Copy link
Contributor Author

lietava commented Apr 8, 2025

@shahor02 , please, merge.

@shahor02
Copy link
Collaborator

shahor02 commented Apr 8, 2025

@lietava to be sure: why do you need to log as LOG(info) ... and then to write explicitly to the mInfoLogger ?

@alibuild
Copy link
Collaborator

alibuild commented Apr 9, 2025

Error while checking build/O2/fullCI_slc9 for fa79907 at 2025-04-09 23:19:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/f48a7012e9311c151f7e327e3d0a18f8e328f0f5/slc9_x86-64/o2checkcode/1.0-local127/etc/modulefiles
++ cat
--

Full log here.

@lietava
Copy link
Contributor Author

lietava commented Apr 10, 2025

@lietava to be sure: why do you need to log as LOG(info) ... and then to write explicitly to the mInfoLogger ?

HI @shahor02 , e.g. when I am debugging locally I do not have infologger. But if it is a problem, please, let me know - I can change.

@shahor02
Copy link
Collaborator

@lietava I meant the messages from the LOG(info) will anyway go to the infologger provided the --infologger-severity accepts it.

@lietava
Copy link
Contributor Author

lietava commented Apr 10, 2025

Ah ok, but I think here the point is that I am sending to infologger message that eg orbit reset was succesfuly written to database (previosly send from other non o2 ctp software) ?

@lietava
Copy link
Contributor Author

lietava commented Apr 10, 2025

I mean it is not error/warning message

@shahor02
Copy link
Collaborator

@lietava if you mean that the LOG(info) messages are filtered out by the settings of your workflow, you can use LOG(important). Do you know how (or who) configures your workflow options?

@lietava
Copy link
Contributor Author

lietava commented Apr 10, 2025

I fully control workflow - it is just one process:
o2-ctp-proxy --ctp-proxy '--channel-config "name=ctp-proxy,type=sub,method=connect,address=ctpo2cs8:50091,rateLogging=30,transport=zeromq"' '--ccdb-host=http://http://ccdb-test.cern.ch:8080/' -b

So I can use some parameter which allows LOG(imprtant) to propaget to indologger without InfoLOgger library ?

@shahor02
Copy link
Collaborator

You can add to your workflow --infologger-severity $INFOLOGGER_SEVERITY option and the INFOLOGGER_SEVERITY value will tell which levels will be propagated to the infologger.
E.g. with INFOLOGGER_SEVERITY="info" everything starting from LOG(info) and higher (e.g. alarm, important, error ...) will go to the IL. For the workflows which produce lot of logs we usually set
INFOLOGGER_SEVERITY="important"
In this case LOG(info) will appear only in your local logs but LOG(important) and higher will go to the IL.

@lietava
Copy link
Contributor Author

lietava commented Apr 10, 2025

@shahor02 : thanks. I fixed the code accordingly.

@shahor02 shahor02 merged commit b78b50c into AliceO2Group:dev Apr 10, 2025
8 checks passed
@lietava
Copy link
Contributor Author

lietava commented May 1, 2025

You can add to your workflow --infologger-severity $INFOLOGGER_SEVERITY option and the INFOLOGGER_SEVERITY value will tell which levels will be propagated to the infologger. E.g. with INFOLOGGER_SEVERITY="info" everything starting from LOG(info) and higher (e.g. alarm, important, error ...) will go to the IL. For the workflows which produce lot of logs we usually set INFOLOGGER_SEVERITY="important" In this case LOG(info) will appear only in your local logs but LOG(important) and higher will go to the IL.

Hi @shahor02 ,
We have done test on staging and we can not make it send message to infologger.
What I mean is that we run our workflow
o2-ctp-proxy --ctp-proxy '--channel-config "name=ctp-proxy,type=sub,method=connect,address=ctpo2cs8:50091,rateLogging=30,transport=zeromq"' '--ccdb-host=[http://http://ccdb-test.cern.ch:8080/](http://http//ccdb-test.cern.ch:8080/)' -b
outside of ecs framework.

@shahor02
Copy link
Collaborator

shahor02 commented May 1, 2025

@lietava did you add an option --infologger-severity info ?

@fpazdic
Copy link

fpazdic commented May 1, 2025

hello @shahor02 we have used it like this:
/opt/o2/bin/o2-ctp-proxy --ctp-proxy '--channel-config "name=ctp-proxy,type=sub,method=connect,address='${MONSCAL_ADDRESS}',rateLogging=30,transport=zeromq"' '--ccdb-host='${MONSCAL_CCDB}'' '--bk-host='${MONSCAL_BK}'' '--qc-host='${MONSCAL_QC}'' -b --infologger-severity $INFOLOGGER_SEVERITY

INFOLOGGER_SEVERITY was set to info.
Moving --inifologger-severity to beginning right after /opt/o2/bin/o2-ctp-proxy did not change anything too

@lietava
Copy link
Contributor Author

lietava commented May 1, 2025

ok, I did not add option --infologger-severity to my workflow. Adding now.

@lietava
Copy link
Contributor Author

lietava commented May 2, 2025

Hi @shahor02 , sorry, I do not understand and can not make it work.
DPL workflow already hase option --infologger-security.
When I try to add it in:
(

void customize(std::vector<ConfigParamSpec>& workflowOptions)
)

it compiles but when I try to run it says:
'[ERROR] error parsing options of o2-ctp-proxy: option '--infologger-severity=info' is ambiguous and matches different versions of '--infologger-severity''

@shahor02
Copy link
Collaborator

shahor02 commented May 2, 2025

@lietava the infologger-severity is a DPL framework option, you should not implement it in your task code but make sure that you provide the severity level on the command line (if you want the messages shown in the IL).
If you had the --infologger-severity info in the task you were trying on staging, then the messages should be in the IL, provided the o2-infologger-daemon was running on the FLP. If the messages are not there, then better ask FLP experts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants