Skip to content

Fixes for the latest clang on osx #14143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 2 commits into from
Apr 7, 2025
Merged

Fixes for the latest clang on osx #14143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e0eb9
Let compiler deduce template type
mpuccio Apr 3, 2025
4ed8443
Avoid deleted copy constructor
mpuccio Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ std::vector<std::string> MultivariatePolynomialHelper<0, 0, false>::getTerms() c
TLinearFitter MultivariatePolynomialHelper<0, 0, false>::getTLinearFitter() const
{
const std::string formula = getTLinearFitterFormula();
TLinearFitter fitter(int32_t(mDim), formula.data(), "");
return fitter;
return TLinearFitter(int32_t(mDim), formula.data(), "");
}

std::vector<float> MultivariatePolynomialHelper<0, 0, false>::fit(TLinearFitter& fitter, std::vector<double>& x, std::vector<double>& y, std::vector<double>& error, const bool clearPoints)
Expand Down
4 changes: 2 additions & 2 deletions Utilities/rANS/include/rANS/compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class makeEncoder
template <typename source_T>
[[nodiscard]] inline static decltype(auto) fromSamples(gsl::span<const source_T> range, size_t renormingPrecision = 0)
{
auto histogram = makeDenseHistogram::template fromSamples(range);
auto histogram = makeDenseHistogram::fromSamples(range);
return makeEncoder::fromHistogram(std::move(histogram), renormingPrecision);
};

Expand Down Expand Up @@ -296,4 +296,4 @@ using decoder_type = decltype(makeDecoder::fromRenormed(RenormedDenseHistogram<s

} // namespace o2::rans::compat

#endif /* RANS_COMPAT_H_ */
#endif /* RANS_COMPAT_H_ */