Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Apr 1, 2025

Hi @shahor02, I added a fit status code, for some local debugging but I think this could be potentially be useful in general, let me know what you think.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3sch Thanks! Looks fine but clang-formatting is needed.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 2, 2025

Hi @shahor02, sure done. Also I found a bug in the collinear fitting which is now also activated in the test, where I also include a summary of the fit status. additionally, the exponential back-off for the logging is simplified (although this could be easily dropped :)).

@f3sch f3sch marked this pull request as ready for review April 2, 2025 09:45
@f3sch f3sch requested a review from a team as a code owner April 2, 2025 09:45
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
shahor02
shahor02 previously approved these changes Apr 2, 2025
@alibuild
Copy link
Collaborator

alibuild commented Apr 2, 2025

Error while checking build/O2/fullCI_slc9 for ead88ec at 2025-04-02 16:41:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(340): error: class "o2::gpu::gpustd::array<int, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(341): error: class "o2::gpu::gpustd::array<__nv_bool, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(342): error: class "o2::gpu::gpustd::array<__nv_bool, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(343): error: class "o2::gpu::gpustd::array<int, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(344): error: class "o2::gpu::gpustd::array<float, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(345): error: class "o2::gpu::gpustd::array<o2::vertexing::DCAFitterN<2>::FitStatus, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(345): error: class "o2::gpu::gpustd::array<o2::vertexing::DCAFitterN<3>::FitStatus, 2UL>" has no member "fill"
ninja: build stopped: subcommand failed.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Apr 2, 2025

Needs #14139

f3sch added 2 commits April 3, 2025 16:21
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild
Copy link
Collaborator

alibuild commented Apr 3, 2025

Error while checking build/O2/fullCI_slc9 for 4774ec2 at 2025-04-03 18:01:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(340): error: class "o2::gpu::gpustd::array<int, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(341): error: class "o2::gpu::gpustd::array<__nv_bool, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(342): error: class "o2::gpu::gpustd::array<__nv_bool, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(343): error: class "o2::gpu::gpustd::array<int, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(344): error: class "o2::gpu::gpustd::array<float, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(345): error: class "o2::gpu::gpustd::array<o2::vertexing::DCAFitterN<2>::FitStatus, 2UL>" has no member "fill"
/sw/SOURCES/O2/14132-slc9_x86-64/0/Common/DCAFitter/include/DCAFitter/DCAFitterN.h(345): error: class "o2::gpu::gpustd::array<o2::vertexing::DCAFitterN<3>::FitStatus, 2UL>" has no member "fill"
ninja: build stopped: subcommand failed.

Full log here.

@f3sch f3sch enabled auto-merge (rebase) April 4, 2025 07:31
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 7, 2025

Hi @shahor02, now after the tag I feel comfortable having this approved, thanks :)

@f3sch
Copy link
Collaborator Author

f3sch commented Apr 7, 2025

@shahor02, actually could you please merge this (I thought that your approval is enough but you do not seem to be in AliceO2Group/framework-admins?)

@shahor02 shahor02 disabled auto-merge April 7, 2025 11:46
@shahor02 shahor02 merged commit cadc5fa into AliceO2Group:dev Apr 7, 2025
12 checks passed
@f3sch f3sch deleted the dcafitter/pr1 branch April 7, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants