-
Notifications
You must be signed in to change notification settings - Fork 483
Common: DCAFitter add fit status code #14132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f3sch Thanks! Looks fine but clang-formatting is needed.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Hi @shahor02, sure done. Also I found a bug in the collinear fitting which is now also activated in the test, where I also include a summary of the fit status. additionally, the exponential back-off for the logging is simplified (although this could be easily dropped :)). |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Error while checking build/O2/fullCI_slc9 for ead88ec at 2025-04-02 16:41: Full log here. |
|
Needs #14139 |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Error while checking build/O2/fullCI_slc9 for 4774ec2 at 2025-04-03 18:01: Full log here. |
|
Hi @shahor02, now after the tag I feel comfortable having this approved, thanks :) |
|
@shahor02, actually could you please merge this (I thought that your approval is enough but you do not seem to be in |
Hi @shahor02, I added a fit status code, for some local debugging but I think this could be potentially be useful in general, let me know what you think.