Skip to content

Common: EnumFlags modifications #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sawenzel merged 3 commits into from
Apr 7, 2025
Merged

Common: EnumFlags modifications #14131

sawenzel merged 3 commits into from
Apr 7, 2025

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Apr 1, 2025

Allow as a delimiter ',', the set method accepts empty strings and a fix.

@f3sch f3sch requested a review from sawenzel as a code owner April 1, 2025 08:46
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Apr 1, 2025
Closed
f3sch added 3 commits April 1, 2025 10:50
@f3sch
Common: EnumFlags turn set with empty string into reset
f126dba 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
Common: EnumFlags fix max rep.
d467e93 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
Common: EnumFlags allow ',' as delimiter
4f8e6a6 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch changed the title Common: EnumFlags turn set with empty string into reset @f3sch Common: EnumFlags turn set with empty string into reset Apr 1, 2025
@f3sch f3sch changed the title Common: EnumFlags turn set with empty string into reset Common: EnumFlags modifications Apr 1, 2025
@f3sch f3sch enabled auto-merge (rebase) April 4, 2025 07:29
@sawenzel sawenzel disabled auto-merge April 7, 2025 09:16
@sawenzel sawenzel merged commit 927ea39 into AliceO2Group:dev Apr 7, 2025
12 checks passed
@f3sch f3sch deleted the enumflags/pr1 branch April 7, 2025 11:48
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 7, 2025

thanks @sawenzel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel sawenzel approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@f3sch @sawenzel