Skip to content

Conversation

@afurs
Copy link
Collaborator

@afurs afurs commented Mar 28, 2025

https://its.cern.ch/jira/browse/AFIT-112

  1. Added new three event bits for reco: IsActiveA, IsActiveC, IsFlangeEvent
  2. Tech bits moved to dedicated recpoint field(+1 byte), mostly for recoQC

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@afurs
Copy link
Collaborator Author

afurs commented Mar 28, 2025

+async-label async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7, async-2024-pp-cpass0, async-2024-PbPb-apass1, async-2024-ppRef-apass1, async-2024-PbPb-apass2, async-2023-PbPb-apass5

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-PbPb-apass5 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-PbPb-apass1 async-2024-PbPb-apass2 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 async-2024-ppRef-apass1 labels Mar 28, 2025
@afurs afurs force-pushed the feature/AFIT-112 branch 2 times, most recently from 8f3f92c to 706c483 Compare March 28, 2025 13:40
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 706c483 at 2025-03-28 18:57:

## sw/BUILD/O2-latest/log
CMake Error at cmake/O2RootMacroExclusionList.cmake:87 (message):

Full log here.

@afurs
Copy link
Collaborator Author

afurs commented Mar 29, 2025

tests on macros failed? This PR does not contain any ROOT macros

@shahor02
Copy link
Collaborator

@afurs could you rebase your branch to dev?

@afurs afurs force-pushed the feature/AFIT-112 branch from 706c483 to 2b40223 Compare March 31, 2025 06:48
@afurs
Copy link
Collaborator Author

afurs commented Mar 31, 2025

Hello @shahor02 , done.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I would prefer this to be validated by FT0. Since you want it to be used for the next Pb passes: did you test it?

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

Looks fine but I would prefer this to be validated by FT0. Since you want it to be used for the next Pb passes: did you test it?

Do you mean approve from FT0 experts? Codeowners(@jotwinow @andreasmolander ) or somebody else? I also attached(first comment and branch name as ID) JIRA ticket related to this PR, ticket was approved by FIT team at the "FIT Software Meeting" on 2024/02/27 An only difference is that I decided also to keep tech bits within rec point entity for next reco QC patch (will be prepared just right after this PR is merged)
I did some tests, but right now I'm repeating them for double check.

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

hotfix is needed

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

Actually we need to reconsider o2::fit::Triggers usage in recpoints, it is kind of overhead since these

uint8_t nChanA = DEFAULT_ZERO; // number of fired channels A side
uint8_t nChanC = DEFAULT_ZERO; // number of fired channels A side
int32_t amplA = DEFAULT_AMP; // sum amplitude A side
int32_t amplC = DEFAULT_AMP; // sum amplitude C side
int16_t timeA = DEFAULT_TIME; // average time A side (shouldn't be used if nChanA == 0)
int16_t timeC = DEFAULT_TIME; // average time C side (shouldn't be used if nChanC == 0)
fields are not informative in view of reconstruction. And they are reconstructed from ChannelData entities at CTF reading stage, w/o any calibration correction. Only trigger field is required for recpoints. But I will keep old logic just in case.

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

@shahor02 I tested again, only found minor incorrectness in the fields I mentioned above in comment. Hotfix applied. I think once some one from FT0 approve this we can go with merging (after successful CICD of course :) ), ok?

@alibuild
Copy link
Collaborator

alibuild commented Apr 1, 2025

Error while checking build/O2/fullCI_slc9 for fd24c67 at 2025-04-01 11:38:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile digi.log
./sim-challenge.logdigi.log:[5390:internal-dpl-ccdb-backend]: [11:38:18][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logdigi.log-[5390:internal-dpl-ccdb-backend]: [11:38:18][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[5391:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[5385:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[5385:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[5385:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[5385:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
[0 more errors; see full log]

Full log here.

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

@shahor02 rebase again? Unrelated issues came in CICD

@shahor02
Copy link
Collaborator

shahor02 commented Apr 1, 2025

@afurs it was a ccdb timeout after the main part of the FST was passed, ignore this.

@afurs
Copy link
Collaborator Author

afurs commented Apr 1, 2025

@shahor02 only build/O2/fullCI_slc9 pipeline failed. Shall we skip it or restart only this one(if we have such functionality in AliecO2 CICD) ?

@shahor02
Copy link
Collaborator

shahor02 commented Apr 1, 2025

@afurs that's ok, shall I merge it?

@afurs
Copy link
Collaborator Author

afurs commented Apr 2, 2025

@shahor02 yes, please

@shahor02 shahor02 merged commit e562336 into AliceO2Group:dev Apr 2, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-PbPb-apass5 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-PbPb-apass1 async-2024-PbPb-apass2 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 async-2024-ppRef-apass1

Development

Successfully merging this pull request may close these issues.

4 participants