Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Mar 21, 2025

If a tpc standalone track fulfils all these criterions then it cannot be thinned:

  • trackqc-tpc-dca DCAxy to PV/MeanVtx < 3 cm
  • trackqc-tpc-pt pt >= 2 GeV
  • trackqc-tpc-cls #clusters >= 80
    Changes and a default values provided by @miranov25.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review March 21, 2025 22:13
@f3sch f3sch requested a review from a team as a code owner March 21, 2025 22:13
@miranov25
Copy link
Contributor

Hello @f3sch,

Thank you for your commit.

Just a quick note — originally I was suggesting a threshold of 0.2 GeV/c, rather than 2 GeV/c.

Do we have an AO2D sample where we can demonstrate the relative data volume contributed by these tracks?

Most of the TPC standalone tracks are short, low‑pT loopers and deep secondaries

Best regards,
Marian

@miranov25
Copy link
Contributor

Support figures from the test TPC reconstruction:

  • Number of clusters
    image
  • fraction of clusters above the threshold
    image

@f3sch
Copy link
Collaborator Author

f3sch commented Mar 22, 2025

@miranov25, I looped over some ranges for the parameters to check the size increase of the final AO2D size.
The upper row shows the size increase relative to the baseline 'qc-fraction 0.1 + thinning'. The lower row shows the same but to 'qc-fraction 0.1 + no thinning'. The points are obtained always with thinning on.

res0 1
res1 0

let me know what you want the final parameters to be.

@alibuild
Copy link
Collaborator

alibuild commented Mar 27, 2025

Error while checking build/O2/fullCI_slc9 for e90c70a at 2025-03-28 19:54:

## sw/BUILD/O2-latest/log
CMake Error at cmake/O2RootMacroExclusionList.cmake:87 (message):

Full log here.

@miranov25
Copy link
Contributor

We should use:
3 cm, 0.2GeV, 80 cluster.
With that can be merged

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 3, 2025

As confirmed by @miranov25 this is approved and thus tagging for merge

@f3sch
Copy link
Collaborator Author

f3sch commented Apr 3, 2025

+async-label async-2024-PbPb-apass2, async-2023-PbPb-apass5, async-2024-ppRef-apass1

@f3sch
Copy link
Collaborator Author

f3sch commented Apr 4, 2025

@shahor02 could this please be merged after review?

@shahor02 shahor02 merged commit 239eeaa into AliceO2Group:dev Apr 4, 2025
12 checks passed
@f3sch f3sch deleted the aod/marian_1 branch April 4, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants