Skip to content

FIT: Geometry alignment macros #14093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 1 commit into from
Mar 28, 2025
Merged

FIT: Geometry alignment macros #14093

shahor02 merged 1 commit into from
Mar 28, 2025

Conversation

@andreasmolander
Copy link
Collaborator

@andreasmolander andreasmolander commented Mar 20, 2025

  • Make misalignment macros usable for creating exact misalignments
  • Add macro for reading misalignments from CCDB
  • Add a couple of plots to hit reading marcos (needed to verify misalignments)
  • Minor change to FV0 geometry to provoding symbolic names of alignable volumes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@afurs
Copy link
Collaborator

afurs commented Mar 20, 2025 •
edited
Loading

@andreasmolander I guess you already tested sim after changes in FV0's Detector and Geometry code, right? P.S. I'm not sure if we have sim tests in CI/CD, thats why I'm asking

afurs
afurs previously approved these changes Mar 20, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Mar 20, 2025

Error while checking build/O2/fullCI_slc9 for 4f4b54f at 2025-03-20 10:41:

## sw/BUILD/O2-latest/log
CMake Error at Detectors/FIT/macros/CMakeLists.txt:43:
CMake Error at cmake/O2ReportNonTestedMacros.cmake:89 (message):

Full log here.

@alibuild alibuild mentioned this pull request Mar 20, 2025
Closed
@andreasmolander
FIT: Geometry alignment macros
fa4d34a 
- Make misalignment macros usable for creating exact misalignments
- Add macro for reading misalignments from CCDB
- Add a couple of plots to hit reading marcos (needed to verify misalignments)
- Minor change to FV0 geometry to provoding symbolic names of alignable volumes
@andreasmolander
Copy link
Collaborator Author

andreasmolander commented Mar 20, 2025

@andreasmolander I guess you already tested sim after changes in FV0's Detector and Geometry code, right? P.S. I'm not sure if we have sim tests in CI/CD, thats why I'm asking

@afurs yes

@alibuild
Copy link
Collaborator

alibuild commented Mar 27, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for fa4d34a at 2025-03-28 01:28:

## sw/BUILD/ONNXRuntime-latest/log
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:26:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:47:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:79:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:155:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:186:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:269:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:314:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:351:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:392:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:433:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:474:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:511:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/collective_defs.cc:548:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:66:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:111:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:167:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:174:12: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:178:12: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:181:17: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:184:17: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/nchwc_schema_defs.cc:196:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.h:50:18: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.h:50:18: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:2904:46: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3012:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3067:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3130:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3177:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3222:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3284:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3362:22: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3422:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3481:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3558:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
/sw/SOURCES/ONNXRuntime/v1.21.0/v1.21.0/onnxruntime/core/graph/contrib_ops/contrib_defs.cc:3607:37: error: conversion from 'onnx::OpSchema' to non-scalar type 'onnx::OpSchemaRegistry::OpSchemaRegisterOnce' requested
ninja: build stopped: subcommand failed.

Full log here.

@afurs afurs enabled auto-merge (squash) March 28, 2025 06:52
@afurs
Copy link
Collaborator

afurs commented Mar 28, 2025

Looks like unrelated CICD issues. @shahor02 could you please merge it?

@shahor02 shahor02 merged commit 3f679a6 into AliceO2Group:dev Mar 28, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afurs afurs afurs approved these changes

@jotwinow jotwinow Awaiting requested review from jotwinow jotwinow is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreasmolander @afurs @alibuild @shahor02