Skip to content

GPU: Remove bogus placement new leading to memory leak #14083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Mar 18, 2025
Merged

GPU: Remove bogus placement new leading to memory leak #14083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions GPU/GPUTracking/Base/GPUReconstruction.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ GPUReconstruction::GPUReconstruction(const GPUSettingsDeviceBackend& cfg) : mHos
mMaster = cfg.master;
cfg.master->mSlaves.emplace_back(this);
}
new (&mProcessingSettings) GPUSettingsProcessing;
new (&mGRPSettings) GPUSettingsGRP;
param().SetDefaults(&mGRPSettings);
mMemoryScalers.reset(new GPUMemorySizeScalers);
for (uint32_t i = 0; i < NSECTORS; i++) {
Expand Down
1 change: 0 additions & 1 deletion GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ using namespace o2::gpu;
GPUReconstruction* GPUReconstruction::CreateInstance(DeviceType type, bool forceType, GPUReconstruction* master)
{
GPUSettingsDeviceBackend cfg;
new (&cfg) GPUSettingsDeviceBackend;
cfg.deviceType = type;
cfg.forceDeviceType = forceType;
cfg.master = master;
Expand Down
2 changes: 1 addition & 1 deletion GPU/GPUTracking/Definitions/GPUSettingsList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ EndConfig()

// Derrived parameters used in GPUParam
BeginHiddenConfig(GPUSettingsParam, param)
AddVariableRTC(dAlpha, float, 0.f) // angular size
AddVariableRTC(dAlpha, float, 0.f) // angular size
AddVariableRTC(assumeConstantBz, int8_t, 0) // Assume a constant magnetic field
AddVariableRTC(toyMCEventsFlag, int8_t, 0) // events were build with home-made event generator
AddVariableRTC(continuousTracking, int8_t, 0) // Continuous tracking, estimate bz and errors for abs(z) = 125cm during seeding
Expand Down