Skip to content

Conversation

@pillot
Copy link
Collaborator

@pillot pillot commented Mar 17, 2025

In very rare cases, data points may be reversed, triggering an error and aborting the scan. This PR turns it into a warning and let the scan continue (the data points are reordered).

@pillot pillot requested review from a team and shahor02 as code owners March 17, 2025 11:32
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

lmassacr
lmassacr previously approved these changes Mar 17, 2025
@davidrohr
Copy link
Collaborator

I assume this will never run in any online or offline scenario, but only locally on a laptop? If this runs without stdin, I guess it will just stall?

@pillot
Copy link
Collaborator Author

pillot commented Mar 18, 2025

I assume this will never run in any online or offline scenario, but only locally on a laptop? If this runs without stdin, I guess it will just stall?

I was going to say yes, as this scan is meant to be run manually. But indeed if someone wants to run it remotely and redirect the output that could be a problem. I will turn it into a warning. Thanks!

@pillot pillot force-pushed the continue-upon-error branch from 5a27c6a to f414d23 Compare March 18, 2025 09:45
@pillot pillot changed the title [MCH] allows to continue after certain errors [MCH] turn error into warning and continue the scan Mar 18, 2025
@pillot pillot force-pushed the continue-upon-error branch from f414d23 to a4747a5 Compare March 18, 2025 09:50
@davidrohr davidrohr merged commit ad59c78 into AliceO2Group:dev Mar 19, 2025
11 of 12 checks passed
@pillot pillot deleted the continue-upon-error branch March 19, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants