-
Notifications
You must be signed in to change notification settings - Fork 483
GPU: Provide general GPUChkErr functionality also externally and several unrelated changes #14062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 061b880 at 2025-03-14 09:52: Full log here. |
test2 GPU: Provide static versions of GPUChkErr() macros
061b880 to
524a9b6
Compare
| // Please #include "GPUReconstruction.h" in your code, if you use these 2! | ||
| #define GPUChkErr(x) GPUChkErrA(x, __FILE__, __LINE__, true) | ||
| #define GPUChkErrI(x) GPUChkErrA(x, __FILE__, __LINE__, false) | ||
| #define GPUChkErrS(x) o2::gpu::internal::GPUReconstructionChkErr(x, __FILE__, __LINE__, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mconcas : You should be able to use GPUChkErrS and GPUChkErrSI statically, if you link against the external provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, I'll try it!
524a9b6 to
1a4806d
Compare
|
@ktf @singiamtel : Could you check the MacOS builder that ran for this PR, this error seems pretty weird: |
|
Yes, it looks indeed quite strange. I assume the issue is: I am looking into it. |
|
I restarted the CI script on the builder and it seems to work. I suspect a recent change in upstream python might have left the SOURCES area in a bad state and while @singiamtel fixed the issue in alisw/alibuild#913 not all the builders where restarted to a clean slate. |
|
@singiamtel I have the impression there is still something wrong with the mac builders. |
|
Ok, after another cleanup of the build machine the error seems to be a genuine complaint about a missing: any idea of how that might happen? |
|
Now one of the Mac CIs passed O2, and then just stopped. Do you think these issues are related to my PR? Or is this a general problem of the MacCI? |
@mconcas : Sorry this took so long :(.
This adds a GPUCommonChkErr.h header, providing my GPUChkErr macros.
Currently, they must be used upon a GPUReconstruction object.
The reason is that I need to dispatch to the backend to get the errorcodes, so I could not easily make it static.
Would this work for you?
I could probably create a static version, which would automatically detect which GPUReconstruction class is created first, and attach to that, and then dispatch to that.
That should in principle cover all use cases, except for if someone would use multiple backends in the same application, which is in principle supported.