Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Mar 13, 2025

  • std::pair is not used anymore
  • Cache entry now has enabled flag, so that it can be skipped when cache is updated at the start of the dataframe if the relevant grouping process function is not enabled
  • Preslice is always enabled as we do not have a way to detect if it is used or not

@ddobrigk please take a note

@aalkin aalkin requested a review from a team as a code owner March 13, 2025 09:56
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aalkin aalkin requested a review from ktf March 13, 2025 09:56
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for a664427 at 2025-03-13 14:55:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1574:82: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1574:82: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1574:82: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1574:82: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1574:82: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
/sw/slc8_x86-64/O2/14057-slc8_x86-64-local1/include/Framework/ASoA.h:1508:96: error: 'const struct o2::framework::Entry' has no member named 'second'
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 27, 2025

Error while checking build/O2/fullCI_slc9 for a80940a at 2025-05-03 10:05:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[22304:internal-dpl-ccdb-backend]: [10:05:36][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[22304:internal-dpl-ccdb-backend]: [10:05:36][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[22304:internal-dpl-ccdb-backend]: [10:05:34][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[22304:internal-dpl-ccdb-backend]: [10:05:34][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alimetal01.cern.ch-1746259528-Vhzrn8) with http code: 0
[22304:internal-dpl-ccdb-backend]: [10:05:34][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[22304:internal-dpl-ccdb-backend]: [10:05:34][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000
[22304:internal-dpl-ccdb-backend]: [10:05:36][ERROR] Exception while running: Fatal error. Rethrowing.
[22304:internal-dpl-ccdb-backend]: [10:05:36][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 22304 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 22304 (exit 128)
[INFO]    - First error: [10:05:34][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (22304) had at least one message above severity 7: Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/1f65fffe80a3e53e6a055b3b5fecf636f86b1ec4/slc9_x86-64/o2checkcode/1.0-local378/etc/modulefiles
++ cat
--

[0 more errors; see full log]

Full log here.

@ktf ktf merged commit 15b4f5f into AliceO2Group:dev May 6, 2025
12 checks passed
@ktf
Copy link
Member

ktf commented May 6, 2025

Tested on hyperloop with Correlations and Histograms. Merging.

@jgrosseo
Copy link
Collaborator

jgrosseo commented May 8, 2025

Tested on hyperloop with Correlations and Histograms. Merging.

@ktf @aalkin It may be that none of those two workflows which you tested uses the slice cache...

@aalkin aalkin deleted the slice-cache-improvement branch December 11, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants