Skip to content

Conversation

@TrifleMichael
Copy link
Contributor

This PR fixes:

  • Not following all redirects provided via "Location" header multimap (in updateLocations function).
  • Not following redirects for multiple alien:/ or file:/ calls (in followRedirect function).
  • Not following available redirects after receiving 4xx http code (in transferFinished function).
  • The headers holding etags and content-type from multiple locations (in header_map_callback function).
  • Improper fail-check for local content retrieval (in loadLocalContentToMemory function).

This commit addresses:
- Not following available redirects after receiving 4xx http code.
- Not following all redirects provided via "Location" header.
- Not following  redirects after failing alien:/ or file:/ retrieval.
- Improper fail-check in CcdbApi::loadLocalContentToMemory.
- The headers holding etags and content-type from multiple locations.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@davidrohr
Copy link
Collaborator

@TrifleMichael @costing : This is supposed to fix the TPC CCDB issue? Is this ready to be merged from your side?
I can give it a short try with the FST, then I'd merge it if OK from your side.

@costing
Copy link
Collaborator

costing commented Mar 10, 2025

Hi David,

Yes, it should fix the new TPC objects. It would be great if you could try it out on a FST!

Thank you,

.costin

@davidrohr davidrohr merged commit dd2d2aa into AliceO2Group:dev Mar 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants