Skip to content

MCH: add cut random fraction setting for the cases with and without ITS #14028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aferrero2707 wants to merge 1 commit into from
Closed

MCH: add cut random fraction setting for the cases with and without ITS #14028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion prodtests/full-system-test/dpl-workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,12 @@ if has_processing_step MUON_SYNC_RECO; then
elif [[ $RUNTYPE == "PHYSICS" && $BEAMTYPE == "pp" ]] || [[ $RUNTYPE == "COSMICS" ]]; then
CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow="MCHTracking.chamberResolutionX=0.4;MCHTracking.chamberResolutionY=0.4;MCHTracking.sigmaCutForTracking=7.;MCHTracking.sigmaCutForImprovement=6.;"
fi
has_detector_reco ITS && [[ $RUNTYPE != "COSMICS" ]] && CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHTimeClusterizer.irFramesOnly=true;"
if has_detector_reco ITS && [[ $RUNTYPE != "COSMICS" ]]; then
CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHTimeClusterizer.irFramesOnly=true;"
[[ -z ${CUT_RANDOM_FRACTION_MCH:-} ]] && CUT_RANDOM_FRACTION_MCH=${CUT_RANDOM_FRACTION_MCH_WITH_ITS:-}
Copy link
Collaborator

@davidrohr davidrohr Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems wrong, I assume you want to check if the _ITS variable is not empty?

Copy link
Collaborator Author

@aferrero2707 aferrero2707 Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not... I want to set CUT_RANDOM_FRACTION_MCH from CUT_RANDOM_FRACTION_MCH_WITH_ITS only if CUT_RANDOM_FRACTION_MCH is not set already.

In other words, I want to be still able to set something like CUT_RANDOM_FRACTION_MCH=0.5 in the extra ENV variables to completely override the defaults.

Does it make sense?

Copy link
Collaborator

@davidrohr davidrohr Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fine with me.
But please check in both assignments that CUT_RANDOM_FRACTION_MCH_WITH_ITS or CUT_RANDOM_FRACTION_MCH_NO_ITS respectively are set. So we don't access an undefined variable accidentally.

Copy link
Collaborator Author

@aferrero2707 aferrero2707 Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidrohr sorry, I missed your comment... doesn't the :- construct in the variables access guarantee that a default empty value is used if the variable is not defined?

else
[[ -z ${CUT_RANDOM_FRACTION_MCH:-} ]] && CUT_RANDOM_FRACTION_MCH=${CUT_RANDOM_FRACTION_MCH_NO_ITS:-}
fi
[[ ! -z ${CUT_RANDOM_FRACTION_MCH:-} ]] && CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHTimeClusterizer.rofRejectionFraction=$CUT_RANDOM_FRACTION_MCH;"
CONFIG_EXTRA_PROCESS_o2_mch_reco_workflow+="MCHStatusMap.useHV=false;MCHDigitFilter.statusMask=3;"
fi
Expand Down