Skip to content

rANS: Suppress bogus compiler warnings, and add / improve some comments #14021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Mar 6, 2025
Merged

rANS: Suppress bogus compiler warnings, and add / improve some comments #14021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GPU/GPUTracking/Base/cuda/GPUReconstructionCUDA.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ int32_t GPUReconstructionCUDA::InitDevice_Runtime()
mInternals = master->mInternals;
GPUFailedMsg(cudaSetDevice(mDeviceId));

GPUInfo("CUDA Initialized from master");
GPUInfo("CUDA Initialisation successfull (from master)");
}

for (uint32_t i = 0; i < mEvents.size(); i++) {
Expand Down
2 changes: 1 addition & 1 deletion GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesHost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include <hip/hip_ext.h>
#include <hipcub/hipcub.hpp>
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshadow"
#pragma GCC diagnostic ignored "-Wshadow" // FIXME: Is this still needed?
#include <thrust/sort.h>
#include <thrust/execution_policy.h>
#include <thrust/device_ptr.h>
Expand Down
1 change: 1 addition & 0 deletions GPU/GPUTracking/Merger/GPUTPCGMMergedTrack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ class GPUTPCGMMergedTrack
float mLastY; //* outer Y
float mLastZ; //* outer Z
uint32_t mFirstClusterRef; //* index of the first track cluster in corresponding cluster arrays
// TODO: Change to 8 bit
uint32_t mNClusters; //* number of track clusters
uint32_t mNClustersFitted; //* number of clusters used in fit
uint8_t mFlags;
Expand Down
3 changes: 3 additions & 0 deletions Utilities/rANS/benchmarks/bench_ransDecode.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,11 @@ void ransDecodeBenchmark(benchmark::State& st, Args&&... args)
using input_data_type = std::remove_cv_t<std::remove_reference_t<decltype(inputData)>>;
using source_type = typename input_data_type::value_type;

#pragma GCC diagnostic push // TODO: Remove me when fixed in GCC
#pragma GCC diagnostic ignored "-Walloc-size-larger-than="
EncodeBuffer<source_type> encodeBuffer{inputData.size()};
DecodeBuffer<source_type> decodeBuffer{inputData.size()};
#pragma GCC diagnostic pop

const auto histogram = makeDenseHistogram::fromSamples(gsl::span<const source_type>(inputData));
Metrics<source_type> metrics{histogram};
Expand Down