-
Notifications
You must be signed in to change notification settings - Fork 483
MCH: enable mapping fixes in ASYNC mode #14006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCH: enable mapping fixes in ASYNC mode #14006
Conversation
The MCHDigitModifier.updateST1=true and MCHDigitModifier.updateST2=true options are added to the MCH reco workflow for the ASYNC processing of real data. This enables the code that fixes the readout mapping in existing CTFs for some parts of ST1 and ST2 detectors. The mapping has also been corrected in the O2 code. Therefore the remapping is disabled for SYNC processing and MC simulations, since they already apply the correct mapping to generate the digits.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
+async-label async-2024-PbPb-apass2, async-2023-PbPb-apass5 |
|
Hi @aferrero2707 , |
|
Well, I just remember that there is a protection on the run number into the code, so that would work also in the dpl-workflow for any past or future data, but I am still not sure it is the correct place to enable this correction. |
|
@pillot my idea here is that the corrections should be applied consistently to all new reconstruction passes from now on, and let the code decide if a given correction should be applied or not based on the run number. Passing this settings via an extra environment variable has the potential risk of forgetting them in some cases. |
|
I see the point. Then it looks fine to me. Thanks ! |
|
Hi @aferrero2707, |
|
@shahor02 could you please check if this can be merged? Thanks a lot! |
The
MCHDigitModifier.updateST1=trueandMCHDigitModifier.updateST2=trueoptions are added to the MCH reco workflow for the ASYNC processing of real data.This enables the code that fixes the readout mapping in existing CTFs for some parts of ST1 and ST2 detectors.
The mapping has also been corrected in the O2 code. Therefore the remapping is disabled for SYNC processing and MC simulations, since they already apply the correct mapping to generate the digits.