Skip to content

Conversation

@nivram-phy
Copy link
Contributor

The new folder that we created with the merged noise map wasn't created at P2. Thus making small modifications to the code so the right function is called.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for a0d84eb at 2025-02-27 17:55:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:109:9: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:109:10: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:110:9: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:111:9: error: stray '\23' in program
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for a0d84eb at 2025-02-27 20:04:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13992-slc9_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:109:9: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc9_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:109:10: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc9_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:110:9: error: stray '\23' in program
/sw/SOURCES/O2/13992-slc9_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:111:9: error: stray '\23' in program
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Hi, the CI errors are genuine, the non-ascii symbols have to be cleaned

NoiseCalibratorSpec.cxx.o -MF Detectors/ITSMFT/MFT/calibration/CMakeFiles/O2lib-MFTCalibration.dir/src/NoiseCalibratorSpec.cxx.o.d -o Detectors/ITSMFT/MFT/calibration/CMakeFiles/O2lib-MFTCalibration.dir/src/NoiseCalibratorSpec.cxx.o -c /sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx /sw/SOURCES/O2/13992-slc8_x86-64/0/Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx:109:9: error: stray '\23' in program 109 | <U+0013><U+0013>sendOutputCcdbDcs(pc.outputs()); | ^~~~~~~~

@nivram-phy nivram-phy requested a review from shahor02 February 28, 2025 15:41
@shahor02 shahor02 merged commit 7c97d71 into AliceO2Group:dev Mar 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants