Skip to content

Conversation

@shahor02
Copy link
Collaborator

@miranov25 @matthias-kleiner the TPCTimeSeriesSpec was crashing on the reconstruction with AB tracks allowed to use ITS IB layers (thus contributing to the PV). This trivial fix will treat them as regular PV contributors for what concerns DCA to PV but the difference between TPC and ITS tracks will be dummy.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@miranov25
Copy link
Contributor

Hello @shahor02
The change looks fine. Please go ahead with the pull request. I also want to commit to including the TRD information, so better to merge now.
@matthias-kleiner, do you wan to make a test before?
I plan to implement TRD information tomorrow or during the weekend to have it in the next production.

Regards
Marian

@shahor02
Copy link
Collaborator Author

@miranov25 I've already run a test for ~30 TF of 559781 (37kHz) with 100% sampling (--enable-unbinned-root-output --sample-unbinned-tsallis --threads 1 --sampling-factor 1.001), if you want to check, the result is in
https://cernbox.cern.ch/s/oVsLiSDKrzSh0Rj

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 9898e60 at 2025-02-20 15:04:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:

Full log here.

@miranov25
Copy link
Contributor

Hello @shahor02
Please go ahead with merge, in case you tested the content. We will return back to that later during the weekend adding TRD.
Marian

@shahor02 shahor02 merged commit 5e43c17 into AliceO2Group:dev Feb 20, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants