Skip to content

Conversation

@andreasmolander
Copy link
Collaborator

The main purpose of the commit:

  • Adding workflows for reading RecPoints for FV0 and FDD, these are needed for MC aQC

Secondary purposes that arose during development:

  • ROOT macro for comparing two RecPoint files
  • Workflows for writing RecPoints added for FT0, FV0 and FDD (i.e. simply standalone RecPoint writers, not related to reconstrucion)
  • The two items above were needed to verify the new RecPoint reader workflows, namely by: reconstructing CTFs -> writing RecPoints to file -> Reading RecPoints from file -> Writing RecPoints to new file -> Comparing the two files
  • Minor cosmetics (e.g. reordering of includes) and utility functions (print and == operator functions)

The main purpose of the commit:
- Adding workflows for reading RecPoints for FV0 and FDD, these are needed for MC aQC

Secondary purposes that arose during development:
- ROOT macro for comparing two RecPoint files
- Workflows for writing RecPoints added for FT0, FV0 and FDD (i.e. simply standalone RecPoint writers, not related to reconstrucion)
- The two items above were needed to verify the new RecPoint reader workflows, namely by: reconstructing CTFs -> writing RecPoints to file -> Reading RecPoints from file -> Writing RecPoints to new file -> Comparing the two files
- Minor cosmetics (e.g. reordering of includes) and utility functions (print and == operator functions)
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@andreasmolander
Copy link
Collaborator Author

New PR to replace the closed #13482. The changes are the same

@andreasmolander
Copy link
Collaborator Author

+async-label async-2024-pbpb-apass4, async-2024-pp-cpass0, async-2024-pp-apass7, async-2024-pp-apass1, async-2023-pbpb-apass3, async-2023-pp-apass4

@github-actions github-actions bot added async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Feb 18, 2025
@github-actions
Copy link
Contributor

Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3

afurs
afurs previously approved these changes Feb 18, 2025
@andreasmolander
Copy link
Collaborator Author

+async-label async-2023-pbpb-apass4, async-2022-pp-apass7, async-2024-PbPb-apass1, async-2024-ppRef-apass1

@github-actions github-actions bot dismissed afurs’s stale review February 18, 2025 14:14

Labels updated; please review again.

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-PbPb-apass1 async-2024-ppRef-apass1 labels Feb 18, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for cbcbf7d at 2025-02-19 22:23:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alissandra07-1740000180-IAlobn) with http code: 0
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:05][ERROR] Exception while running: Fatal error. Rethrowing.
./mftmchMatch.log[17334:internal-dpl-ccdb-backend]: [22:23:05][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-globalfwd-matcher-workflow, device shutting down. Reason: Fatal error
./mftmchMatch.log[ERROR] Workflow crashed - PID 17334 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./mftmchMatch.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 17334 (exit 128)
./mftmchMatch.log[INFO]    - First error: [22:23:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./mftmchMatch.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (17334) had at least one message above severity 5: Unable to find object CTP/Calib/OrbitReset/1546300800000
./mchmidMatch.log[14179:muon-track-writer]: [22:22:01][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./sim-challenge.logDetected critical problem in logfile mftmchMatch.log
./sim-challenge.logmftmchMatch.log:[17334:internal-dpl-ccdb-backend]: [22:23:05][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logmftmchMatch.log-[17334:internal-dpl-ccdb-backend]: [22:23:05][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-globalfwd-matcher-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alissandra07-1740000180-IAlobn) with http code: 0
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:04][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:05][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[17334:internal-dpl-ccdb-backend]: [22:23:05][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-globalfwd-matcher-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 17334 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 17334 (exit 128)
./sim-challenge.log[INFO]    - First error: [22:23:04][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (17334) had at least one message above severity 5: Unable to find object CTP/Calib/OrbitReset/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
[0 more errors; see full log]

Full log here.

@sawenzel sawenzel requested a review from shahor02 March 18, 2025 12:26
@sawenzel
Copy link
Collaborator

@shahor02 : Could you take a look and treat this PR?

@shahor02 shahor02 merged commit ed07815 into AliceO2Group:dev Mar 18, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-PbPb-apass1 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 async-2024-ppRef-apass1

Development

Successfully merging this pull request may close these issues.

5 participants