DPL: trigger runtime error in case of duplicate processor names #13963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
davidrohr
previously approved these changes
Feb 13, 2025
Collaborator
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Great, thx, though didn't verify that it actually works.
Collaborator
Author
|
I checked it with two workflows and one of the dummy workflows where I changed the name of one processor to match one of the other workflows. I got the error whenever I included the dummy workflow, and never without it. |
ktf
reviewed
Feb 14, 2025
| auto found = std::find_if(physicalWorkflow.begin(), physicalWorkflow.end(), | ||
| [&name = dp.name](DataProcessorSpec const& spec) { return spec.name == name; }); | ||
| if (found == physicalWorkflow.end()) { | ||
| // also checking the workflow for processors with the same name but from a different executable, |
Collaborator
|
Error while checking build/O2/fullCI for 419b9db at 2025-02-17 14:54: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 419b9db at 2025-02-14 21:42: Full log here. |
ehellbar
force-pushed
the
processornames
branch
from
419b9db to
841b74a
Compare
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 841b74a at 2025-02-18 19:31: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI for 841b74a at 2025-02-18 21:48: Full log here. |
…g its metadata to store executable
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding processors to the workflow if they have the same name as an already added processor but come from a different executable. This will trigger a runtime error in the
MATERIALISE_WORKFLOWstate inAliceO2/Framework/Core/src/WorkflowHelpers.cxx
Line 935 in 28d9c76