Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Feb 13, 2025

In a specific case where the index would skip exactly one row, the binary search would stop on the skipped row instead of a target one, missing a correct entry.

@ddobrigk This fixes the specific converted Run 2 data issue we were discussing via email.

@aalkin aalkin requested a review from a team as a code owner February 13, 2025 11:34
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ddobrigk
Copy link
Contributor

Many many thanks @aalkin , it's really great to have this fixed!!!

@aalkin aalkin requested a review from ktf February 13, 2025 12:06
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for e672d0c at 2025-02-15 18:46:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile zdcreco.log
./sim-challenge.logzdcreco.log:[18341:internal-dpl-ccdb-backend]: [17:46:37][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logzdcreco.log-[18341:internal-dpl-ccdb-backend]: [17:46:37][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-zdc-digits-reco, device shutting down. Reason: Fatal error
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1546300800000 (agent_id: alimetal03.cern.ch-1739641595-ZTRDZ1) with http code: 0
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[18341:internal-dpl-ccdb-backend]: [17:46:37][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-zdc-digits-reco, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 18341 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 18341 (exit 128)
./sim-challenge.log[INFO]    - First error: [17:46:37][FATAL] Unable to find object CTP/Calib/OrbitReset/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (18341) had at least one message above severity 5: Unable to find object CTP/Calib/OrbitReset/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
[0 more errors; see full log]

Full log here.

@ktf ktf merged commit 8069cf6 into AliceO2Group:dev Feb 17, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants