Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Feb 10, 2025

Remove abstraction-leaking specializations of OptionManager and OutputManager, to unblock #13947

  • Move configurables to the analysis task implementation of aod-to-hepmc converter and intialize the converter in init()
  • Add a tiny single-instance service to hold the pointer to the converter so it can trigger the post run action

@aalkin aalkin requested review from a team, jackal1-66 and sawenzel as code owners February 10, 2025 10:40
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aalkin aalkin requested a review from ktf February 10, 2025 10:40
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 9f9fafd at 2025-02-10 14:21:

++ cp /sw/slc9_x86-64/O2/13950-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonprefix([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/13950-slc9_x86-64/0/
++ [[ -e /sw/SOURCES/O2/13950-slc9_x86-64/0//CMakeLists.txt ]]

Full log here.

@ktf
Copy link
Member

ktf commented Feb 11, 2025

@sawenzel @jackal1-66 any objections to this? It is needed to merge #13947 which goes towards simplifying the whole AnalysisManagers business.

@sawenzel
Copy link
Collaborator

Cannot really judge but I have no objections if it helps you.

@aalkin
Copy link
Member Author

aalkin commented Feb 11, 2025

I have tested that converter still runs. However, it is not currently used, as we are still lacking Rivet workflow.

@ktf ktf merged commit f4de6bb into AliceO2Group:dev Feb 12, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants