Skip to content

Conversation

@aferrero2707
Copy link
Collaborator

Added option for using the track time when selecting the MFT candidates to be matched with a given MCH track.
This helps to reduce the number of candidates when the MCH track is already matched with MID and therefore has a precise timing. In this case the number of MCH tracks that need to be combined with MFT tracks from two adjacent ROFs is strongly reduced.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aferrero2707
Copy link
Collaborator Author

@MauriceCoke this is the PR discussed at the matching meeting today.

The MFT ROFs are selected by comparing them the MCH ROFs here. The actual time bracket of the MCH track is not used, although it is much more precise in the case of MCH-MID tracks (see here).

The PR introduces a further comparison between the track time and the MFT ROFs (disabled by default to preserve the original behavior).

Added option for using the track time when selecting the MFT candidates
to be matched with a given MCH track.
This helps to reduce the number of candidates when the MCH track is
already matched with MID and therefore has a precise timing.
In this case the number of MCH tracks that need to be combined with
MFT tracks from two adjacent ROFs is strongly reduced.
@aferrero2707 aferrero2707 force-pushed the muon-mft-matching-use-track-time branch from 9179547 to e2a7086 Compare January 28, 2025 21:42
@alibuild
Copy link
Collaborator

alibuild commented Jan 29, 2025

Error while checking build/O2/fullCI for e2a7086 at 2025-02-05 12:58:

## sw/BUILD/o2codechecker-latest/log
100% tests passed, 0 tests failed out of 1


## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[33486:internal-dpl-ccdb-backend]: [11:58:25][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[33486:internal-dpl-ccdb-backend]: [11:58:25][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[33486:internal-dpl-ccdb-backend]: [11:58:24][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
[33486:internal-dpl-ccdb-backend]: [11:58:24][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1550600800000 (agent_id: alimetal03.cern.ch-1738756700-yxfejx) with http code: 0
[33486:internal-dpl-ccdb-backend]: [11:58:24][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[33486:internal-dpl-ccdb-backend]: [11:58:25][ERROR] Exception while running: Fatal error. Rethrowing.
[33486:internal-dpl-ccdb-backend]: [11:58:25][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 33486 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] websocket_server_callback: Error while reading from websocketconnection reset by peer
[ERROR]  - Device internal-dpl-ccdb-backend: pid 33486 (exit 128)
[INFO]    - First error: [11:58:24][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (33486) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/f773bce85a204eece54801c466886da71cc95657/slc8_x86-64/o2checkcode/1.0-local1/etc/modulefiles
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Feb 4, 2025

Error while checking build/O2/fullCI_slc9 for e2a7086 at 2025-02-11 17:18:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-RTC-test-latest/log
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:72:40: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:118:44: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:77: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:167: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:72:40: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
rec.tpc.globalTrackingMinRows && tracker.TrackHits()[tmpHit]/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:118:44: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
.RowIndex() < tracker.Pa/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:77: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
am().rec./sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:167: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:130:65: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:130:65: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:134:63: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:134:63: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:114: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:243: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:147:65: error: no member named 'globalTrackingYRangeUpper' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:147:65: error: no member named 'globalTrackingYRangeUpper' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:151:63: error: no member named 'globalTrackingYRangeUpper' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:151:63: error: no member named 'globalTrackingYRangeUpper' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:72:40: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:118:44: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:77: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:167: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:72:40: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:118:44: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:130:65: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:126:167: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:134:63: error: no member named 'globalTrackingYRangeLower' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:114: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:243: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:114: error: no member named 'globalTrackingMinRows' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:143:243: error: no member named 'globalTrackingRowRange' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:72:40: error: no member named 'globalTrackingMinHits' in 'o2::gpu::GPUSettingsRecTPC'
/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:147:65:/sw/SOURCES/O2/13911-slc9_x86-64/0/GPU/GPUTracking/SliceTracker/GPUTPCGlobalTracking.cxx:151:63: error: no member named 'globalTrackingYRangeUpper' in 'o2::gpu::GPUSettingsRecTPC'
[0 more errors; see full log]

Full log here.

@mcoquet642
Copy link
Collaborator

Thanks Andrea, this looks fine to me. @shahor02 could you have a look ?

@shahor02 shahor02 merged commit 28d9c76 into AliceO2Group:dev Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants